spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

github-sweeper: flagged cells cannot be unflagged via handleCellClick #1002

New Issue
Closed
opened 2026-08-12 05:51:03 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 05:51:03 +00:00
Owner
Copy link
Copy source

Bug

In GithubSweeperComponent.handleCellClick, the early guard returns when grid[y][x].flagged is true before the right-click / ctrl-click branch that calls toggleFlag.

Effect

Players can flag a cell but cannot unflag it through the click handler (the UI path). toggleFlag itself correctly flips both ways.

Repro (unit)

Pinned by github-sweeper.component.spec.ts — "BUG: handleCellClick cannot unflag".

Fix sketch

Reorder so the flag toggle runs before (or instead of) the flagged early-return, e.g. check button === 2 || ctrlKey first, then bail on revealed/gameOver.

## Bug In `GithubSweeperComponent.handleCellClick`, the early guard returns when `grid[y][x].flagged` is true **before** the right-click / ctrl-click branch that calls `toggleFlag`. ## Effect Players can flag a cell but cannot unflag it through the click handler (the UI path). `toggleFlag` itself correctly flips both ways. ## Repro (unit) Pinned by `github-sweeper.component.spec.ts` — "BUG: handleCellClick cannot unflag". ## Fix sketch Reorder so the flag toggle runs before (or instead of) the flagged early-return, e.g. check `button === 2 || ctrlKey` first, then bail on revealed/gameOver.
spikerj commented 2026-08-13 23:23:41 +00:00
Author
Owner
Copy link
Copy source

Already present on spikersoft-angular master. handleCellClick runs the right-click/ctrl flag toggle before the flagged early-return, so cells can be unflagged. Closing.

Already present on `spikersoft-angular` `master`. `handleCellClick` runs the right-click/ctrl flag toggle before the flagged early-return, so cells can be unflagged. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1002