spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Platform Adoption coverage link encodes query string into routerLink path #1003

New Issue
Closed
opened 2026-08-12 05:51:09 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 05:51:09 +00:00
Owner
Copy link
Copy source

Summary

PlatformAdoptionComponent builds deep-links as a single string containing a query (/admin/activity-coverage?userId=…) and binds that string to [routerLink].

Angular treats the whole value as a path, so ? / = are percent-encoded (%3FuserId%3D…). Staff clicking Action-level coverage → never land on ?userId= as a real query param.

Expected

Use path + queryParams separately, e.g.:

<a [routerLink]="['/admin/activity-coverage']" [queryParams]="{ userId: user.keycloakUserId }">

or a plain href if that is intentional.

Found by

Wave 6 coverage agent a1 — platform-adoption.render.spec.ts (documents current %3F encoding).

Location

  • projects/spikersoft/src/app/_components/admin/platform-adoption/platform-adoption.component.ts (coverageLink)
  • …/platform-adoption.component.html ([routerLink]="coverageLink(…)")
## Summary `PlatformAdoptionComponent` builds deep-links as a single string containing a query (`/admin/activity-coverage?userId=…`) and binds that string to `[routerLink]`. Angular treats the whole value as a **path**, so `?` / `=` are percent-encoded (`%3FuserId%3D…`). Staff clicking **Action-level coverage →** never land on `?userId=` as a real query param. ## Expected Use path + queryParams separately, e.g.: ```html <a [routerLink]="['/admin/activity-coverage']" [queryParams]="{ userId: user.keycloakUserId }"> ``` or a plain `href` if that is intentional. ## Found by Wave 6 coverage agent a1 — `platform-adoption.render.spec.ts` (documents current `%3F` encoding). ## Location - `projects/spikersoft/src/app/_components/admin/platform-adoption/platform-adoption.component.ts` (`coverageLink`) - `…/platform-adoption.component.html` (`[routerLink]="coverageLink(…)")`
spikerj commented 2026-08-14 03:15:33 +00:00
Author
Owner
Copy link
Copy source

Already on master (not part of PR #819). Platform Adoption coverage links already use path + queryParams, so ?userId= is no longer encoded into the routerLink path. Closing.

Already on `master` (not part of PR #819). Platform Adoption coverage links already use path + queryParams, so ?userId= is no longer encoded into the routerLink path. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1003