spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

GameServerService.normalizeSpacecraftListEvent drops spacecraft velocity fields #1006

New Issue
Closed
opened 2026-08-12 06:25:38 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 06:25:38 +00:00
Owner
Copy link
Copy source

Summary

normalizeSpacecraftListEvent maps position/rotation/mass/docking fields from PascalCase or camelCase, but never maps VelocityX/Y/Z (or camelCase equivalents) onto the normalized spacecraft objects.

handleSpacecraftList then seeds _entityStateCache with sc.velocityX ?? 0 (always 0), so initial list velocities from the server are discarded.

Repro

Unit coverage in game-server.events-space.spec.ts (Wave 6 a5): fire a SpacecraftList with VelocityX/velocityX set — cache entry velocity stays 0.

Expected

Normalize should include velocityX/Y/Z from VelocityX/Y/Z or camelCase, and the entity-state cache should seed those values.

Location

projects/spikersoft/src/app/_services/game-server/game-server.service.ts — normalizeSpacecraftListEvent / handleSpacecraftList.

## Summary `normalizeSpacecraftListEvent` maps position/rotation/mass/docking fields from PascalCase or camelCase, but never maps `VelocityX/Y/Z` (or camelCase equivalents) onto the normalized spacecraft objects. `handleSpacecraftList` then seeds `_entityStateCache` with `sc.velocityX ?? 0` (always `0`), so initial list velocities from the server are discarded. ## Repro Unit coverage in `game-server.events-space.spec.ts` (Wave 6 a5): fire a `SpacecraftList` with `VelocityX`/`velocityX` set — cache entry velocity stays `0`. ## Expected Normalize should include `velocityX/Y/Z` from `VelocityX/Y/Z` or camelCase, and the entity-state cache should seed those values. ## Location `projects/spikersoft/src/app/_services/game-server/game-server.service.ts` — `normalizeSpacecraftListEvent` / `handleSpacecraftList`.
spikerj commented 2026-08-14 03:15:34 +00:00
Author
Owner
Copy link
Copy source

Already on master (not part of PR #819). normalizeSpacecraftListEvent already maps VelocityX/Y/Z onto the entity-state cache. Closing.

Already on `master` (not part of PR #819). normalizeSpacecraftListEvent already maps VelocityX/Y/Z onto the entity-state cache. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1006