spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Dashboard passport scan error leaves passportScanning stuck true #1011

New Issue
Closed
opened 2026-08-12 07:10:08 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 07:10:08 +00:00
Owner
Copy link
Copy source

Summary

SpikersoftDashboardComponent.onPassportScanRequested clears passportScanning only in the Observable complete handler. On OCR/scanPassport error, RxJS does not emit complete, so passportScanning stays true and the UI can keep showing a spinner after a failed scan.

Same failure class as the already-documented blog-load bug (loadingBlog stuck when getAllBlogPosts errors).

Location

projects/spikersoft/src/app/_components/spikersoft-dashboard/spikersoft-dashboard.component.ts — onPassportScanRequested.

Repro (unit)

Wave6 a7 close/passport suite asserts passportScanning() === true after a throwError from ApplicationService.scanPassport.

Expected

passportScanning returns to false in both success and error paths (e.g. clear in error as well as complete, or use finalize).

Found by

Wave 6 LOOP tick 6 — coverage-wave6-a7 (meaningful coverage).

## Summary `SpikersoftDashboardComponent.onPassportScanRequested` clears `passportScanning` only in the Observable `complete` handler. On OCR/`scanPassport` **error**, RxJS does not emit `complete`, so `passportScanning` stays `true` and the UI can keep showing a spinner after a failed scan. Same failure class as the already-documented blog-load bug (`loadingBlog` stuck when `getAllBlogPosts` errors). ## Location `projects/spikersoft/src/app/_components/spikersoft-dashboard/spikersoft-dashboard.component.ts` — `onPassportScanRequested`. ## Repro (unit) Wave6 a7 close/passport suite asserts `passportScanning() === true` after a `throwError` from `ApplicationService.scanPassport`. ## Expected `passportScanning` returns to `false` in both success and error paths (e.g. clear in `error` as well as `complete`, or use `finalize`). ## Found by Wave 6 LOOP tick 6 — coverage-wave6-a7 (meaningful coverage).
spikerj commented 2026-08-14 03:15:33 +00:00
Author
Owner
Copy link
Copy source

Already on master (not part of PR #819). Dashboard passport scan already clears passportScanning on the error path, so a failed OCR no longer leaves the spinner stuck. Closing.

Already on `master` (not part of PR #819). Dashboard passport scan already clears passportScanning on the error path, so a failed OCR no longer leaves the spinner stuck. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1011