spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

SmsFormValidationService requiredTrue message never matches Angular {required:true} #1015

New Issue
Closed
opened 2026-08-12 07:27:33 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 07:27:33 +00:00
Owner
Copy link
Copy source

Summary

SmsFormValidationService looks up a requiredTrue error key for the agree/consent control, but Angular’s Validators.requiredTrue emits { required: true }. The “You must agree…” message therefore never surfaces via validateForm.

Found by

Wave 6 coverage tick 7 a3 — SMS form-validation specs (ce1736f4).

Expected

Either map required → the agree message for that control, or use a custom validator that sets requiredTrue.

Impact

Users can fail validation without seeing the intended consent error copy.

## Summary `SmsFormValidationService` looks up a `requiredTrue` error key for the agree/consent control, but Angular’s `Validators.requiredTrue` emits `{ required: true }`. The “You must agree…” message therefore never surfaces via `validateForm`. ## Found by Wave 6 coverage tick 7 a3 — SMS form-validation specs (`ce1736f4`). ## Expected Either map `required` → the agree message for that control, or use a custom validator that sets `requiredTrue`. ## Impact Users can fail validation without seeing the intended consent error copy.
spikerj commented 2026-08-14 03:14:33 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). SmsFormValidationService requiredTrue matches Angular {required:true}. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). SmsFormValidationService requiredTrue matches Angular {required:true}. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1015