spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

UserListComponent: selectedUsers plain Set breaks OnPush bulk-selection UI #1018

New Issue
Closed
opened 2026-08-12 08:08:53 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 08:08:53 +00:00
Owner
Copy link
Copy source

Summary

UserListComponent.selectedUsers is a plain Set. In-place mutations (add/delete) do not create a new reference, so OnPush does not re-render @if (selectedUsers.size) / bulk-selection chrome even after detectChanges(). The checkbox event path that replaces or otherwise triggers CD works; programmatic/in-place Set updates can leave the toolbar stale.

Found by

Wave 6 coverage tick 9 a1 — characterized in user-list render suite (3a5d96cc / ledger).

Expected

Use a signal, immutable Set replacement (selectedUsers = new Set(...)), or markForCheck after mutations so bulk-selection UI stays in sync.

## Summary `UserListComponent.selectedUsers` is a plain `Set`. In-place mutations (add/delete) do not create a new reference, so OnPush does not re-render `@if (selectedUsers.size)` / bulk-selection chrome even after `detectChanges()`. The checkbox event path that replaces or otherwise triggers CD works; programmatic/in-place Set updates can leave the toolbar stale. ## Found by Wave 6 coverage tick 9 a1 — characterized in user-list render suite (`3a5d96cc` / ledger). ## Expected Use a signal, immutable Set replacement (`selectedUsers = new Set(...)`), or markForCheck after mutations so bulk-selection UI stays in sync.
spikerj commented 2026-08-14 03:14:31 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). UserList selectedUsers is a signal so OnPush bulk-selection updates. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). UserList selectedUsers is a signal so OnPush bulk-selection updates. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1018