marks-address: getDistanceMatrixInformation GETs literal url&key=… string #1020

New Issue

2026-08-12T08:24:47Z

spikerj commented

2026-08-12 08:24:47 +00:00

Summary

getDistanceMatrixInformation appears to build a Distance Matrix URL, then issues an HTTP GET against the literal string url&key=… instead of the constructed URL. Distance/ETA calls cannot succeed.

Found by

Wave 6 coverage tick 10 a1 (f029b1c1 / related).

Also noted

Private handleError looks unreachable from the live call paths (leftover LH).

Expected

GET the assembled Maps API URL (with key/query params applied correctly).

## Summary `getDistanceMatrixInformation` appears to build a Distance Matrix URL, then issues an HTTP GET against the literal string `url&key=…` instead of the constructed URL. Distance/ETA calls cannot succeed. ## Found by Wave 6 coverage tick 10 a1 (`f029b1c1` / related). ## Also noted Private `handleError` looks unreachable from the live call paths (leftover LH). ## Expected GET the assembled Maps API URL (with key/query params applied correctly).

spikerj commented

2026-08-13 06:53:51 +00:00

Wave 7 tick 7 a7 — correction from leftover coverage on marks-address.service.ts.

The GET does interpolate ${url} (not a literal url&key= string). The live bug is the URL builder:

origin {lat} is replaced with lat + ",", so origins become 1,,2 (doubled comma)
waypoint/destination segments are concat("{lat}", lat + ",") then .replace("{long}", …) — {long} is already gone from the origin replace, so dest stays {lat}3,{lat}5,

Pinned by marks-address.service.leftovers.spec.ts (empty waypoints / two waypoints) plus the existing characterization in marks-address.service.spec.ts.

handleError is confirmed dead: none of getDistanceMatrixInformation / getGoogleGeocodedInformation / verifyAddress pipe catchError. The leftover LH (61–69) is now covered as the swallow-and-fallback contract if it is ever wired.

Wave 7 tick 7 a7 — correction from leftover coverage on `marks-address.service.ts`. The GET **does** interpolate `${url}` (not a literal `url&key=` string). The live bug is the **URL builder**: - origin `{lat}` is replaced with `lat + ","`, so origins become `1,,2` (doubled comma) - waypoint/destination segments are `concat("{lat}", lat + ",")` then `.replace("{long}", …)` — `{long}` is already gone from the origin replace, so dest stays `{lat}3,{lat}5,` Pinned by `marks-address.service.leftovers.spec.ts` (empty waypoints / two waypoints) plus the existing characterization in `marks-address.service.spec.ts`. `handleError` is confirmed dead: none of `getDistanceMatrixInformation` / `getGoogleGeocodedInformation` / `verifyAddress` pipe `catchError`. The leftover LH (61–69) is now covered as the swallow-and-fallback contract if it is ever wired.

spikerj commented

2026-08-14 03:14:35 +00:00

Resolved in spikersoft-angular PR #819 (merged to master). marks-address Distance Matrix URL no longer doubles commas or leftover {lat}. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). marks-address Distance Matrix URL no longer doubles commas or leftover {lat}. Closing.

spikerj closed this issue

2026-08-14 03:14:35 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1020