spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Duality: Space key toggles mode without activity tracking #1025

New Issue
Closed
opened 2026-08-12 08:43:37 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 08:43:37 +00:00
Owner
Copy link
Copy source

Summary

In DualityGameComponent, the on-screen mode button calls toggleMode() which tracks games.duality / toggle-mode before flipping modes. Pressing Space on the canvas flips mode directly in onKeyDown and never calls ActivityTrackingService.track.

Impact

Keyboard users who switch pacman↔snake via Space are invisible in analytics; button toggles are counted. Funnel / engagement metrics under-count mode switches.

Repro

  1. Open Duality game.
  2. Focus the canvas and press Space → mode flips, no track.
  3. Click the mode toggle button → track("games.duality", "toggle-mode") fires.

Expected

Space and the button should share the same toggle path (or Space should also track).

Source

projects/spikersoft/src/app/_components/_games/duality/duality-game.component.ts — onKeyDown vs toggleMode.
Found during Wave 6 coverage tick 11 (a3).

## Summary In `DualityGameComponent`, the on-screen mode button calls `toggleMode()` which tracks `games.duality` / `toggle-mode` before flipping modes. Pressing **Space** on the canvas flips `mode` directly in `onKeyDown` and never calls `ActivityTrackingService.track`. ## Impact Keyboard users who switch pacman↔snake via Space are invisible in analytics; button toggles are counted. Funnel / engagement metrics under-count mode switches. ## Repro 1. Open Duality game. 2. Focus the canvas and press Space → mode flips, no track. 3. Click the mode toggle button → `track("games.duality", "toggle-mode")` fires. ## Expected Space and the button should share the same toggle path (or Space should also track). ## Source `projects/spikersoft/src/app/_components/_games/duality/duality-game.component.ts` — `onKeyDown` vs `toggleMode`. Found during Wave 6 coverage tick 11 (a3).
spikerj commented 2026-08-14 03:14:35 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). Duality Space key tracks activity when toggling mode. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). Duality Space key tracks activity when toggling mode. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1025