spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

ArtAssetLibrary filterState clobbered by URL effect before router.navigate settles #1026

New Issue
Closed
opened 2026-08-12 09:02:46 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 09:02:46 +00:00
Owner
Copy link
Copy source

Bug

ArtAssetLibraryComponent.applyFilter sets filterState then void this.router.navigate(...). The constructor effect reads both queryParamMap() and filterState(). When filterState updates, the effect re-runs while queryParamMap is still stale, sees a mismatch, and writes the old URL filter back into filterState — wiping the just-typed search / chip change until navigation completes.

Where

libraries/features/art-studio/src/lib/art-asset-library/art-asset-library.component.ts — applyFilter + the URL sync effect in the constructor.

Would catch

Typing in the library search (or toggling a chip) then flushing CD/effects before the router emits new query params leaves gridFilter().search empty and the grid unfiltered.

Suggested fix

Ignore URL→state sync while a local write is in flight (generation token / skip-echo flag), or only sync from URL when queryParamMap itself changed (not when filterState changed).

## Bug `ArtAssetLibraryComponent.applyFilter` sets `filterState` then `void this.router.navigate(...)`. The constructor `effect` reads both `queryParamMap()` and `filterState()`. When `filterState` updates, the effect re-runs while `queryParamMap` is still stale, sees a mismatch, and **writes the old URL filter back into `filterState`** — wiping the just-typed search / chip change until navigation completes. ## Where `libraries/features/art-studio/src/lib/art-asset-library/art-asset-library.component.ts` — `applyFilter` + the URL sync `effect` in the constructor. ## Would catch Typing in the library search (or toggling a chip) then flushing CD/effects before the router emits new query params leaves `gridFilter().search` empty and the grid unfiltered. ## Suggested fix Ignore URL→state sync while a local write is in flight (generation token / skip-echo flag), or only sync from URL when `queryParamMap` itself changed (not when `filterState` changed).
spikerj commented 2026-08-14 03:14:34 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). ArtAssetLibrary filterState is not clobbered by the URL effect before navigate settles. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). ArtAssetLibrary filterState is not clobbered by the URL effect before navigate settles. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1026