spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

hex-tower: solo Resign finishes state but never flips viewPhase / match-end #1027

New Issue
Closed
opened 2026-08-12 09:17:06 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-12 09:17:06 +00:00
Owner
Copy link
Copy source

Summary

LocalMatchClient only invokes onPhaseTransition from the Tick loop when a Tick produces phase === "finished". Resign (and any other dispatch that finishes the match) updates reducer state via emit() but never calls onPhaseTransition.

Impact

Solo resign leaves HexTowerDefenceComponent.viewPhase on "playing" while state.phase is already "finished", so the finished HUD / activity match-end track never run.

Expected

Any transition into finished (Tick or Resign / defeat via action) should notify onPhaseTransition once.

Repro (unit)

hex-tower-defence.match-hud.spec.ts — "solo resign finishes reducer state but leaves viewPhase on playing".

Suggested fix

In LocalMatchClient.dispatch (or after emit), if next.phase === "finished" && !finishedNotified, set the flag and call onPhaseTransition?.(next).

## Summary `LocalMatchClient` only invokes `onPhaseTransition` from the Tick loop when a Tick produces `phase === "finished"`. Resign (and any other `dispatch` that finishes the match) updates reducer state via `emit()` but never calls `onPhaseTransition`. ## Impact Solo resign leaves `HexTowerDefenceComponent.viewPhase` on `"playing"` while `state.phase` is already `"finished"`, so the finished HUD / activity `match-end` track never run. ## Expected Any transition into `finished` (Tick **or** Resign / defeat via action) should notify `onPhaseTransition` once. ## Repro (unit) `hex-tower-defence.match-hud.spec.ts` — "solo resign finishes reducer state but leaves viewPhase on playing". ## Suggested fix In `LocalMatchClient.dispatch` (or after emit), if `next.phase === "finished" && !finishedNotified`, set the flag and call `onPhaseTransition?.(next)`.
spikerj commented 2026-08-13 23:23:45 +00:00
Author
Owner
Copy link
Copy source

Already present on spikersoft-angular master. LocalMatchClient.dispatch notifies onPhaseTransition when Resign (or any action) moves the match to finished, so solo resign flips viewPhase and runs match-end. Closing.

Already present on `spikersoft-angular` `master`. `LocalMatchClient.dispatch` notifies `onPhaseTransition` when Resign (or any action) moves the match to `finished`, so solo resign flips `viewPhase` and runs match-end. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1027