spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

dungeon camp: createQuestBoard always returns null because GLTFLoader.load is async #1028

New Issue
Closed
opened 2026-08-13 04:43:06 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 04:43:06 +00:00
Owner
Copy link
Copy source

Discovered while writing Wave 7 coverage for projects/spikersoft/src/app/_components/_games/dungeon-crawler/camp.ts.

createQuestBoard assigns questBoardRef only inside the GLTFLoader.load success/error callbacks, then immediately return questBoardRef. Because load is asynchronous, the returned handle is always null in production. createCamp therefore always reports questBoard: null.

Callers currently ignore the return value (dungeon-crawler.component.ts keeps only walls/torches) and animateQuestIndicator looks the board up by scene.getObjectByName("questBoard"), so gameplay is not broken. The collision wall is also missing from camp.walls until the callback fires, so the player can walk through the board for a frame (or forever if the GLB never loads).

Fix: return a THREE.Group placeholder synchronously, parent the loaded model into it, and push the collision mesh before returning — or make createCamp async.

Characterization: camp.create.spec.ts — "returns a null questBoard handle when GLB load stays pending (async gap)".

Discovered while writing Wave 7 coverage for `projects/spikersoft/src/app/_components/_games/dungeon-crawler/camp.ts`. `createQuestBoard` assigns `questBoardRef` only inside the `GLTFLoader.load` success/error callbacks, then immediately `return questBoardRef`. Because `load` is asynchronous, the returned handle is always `null` in production. `createCamp` therefore always reports `questBoard: null`. Callers currently ignore the return value (`dungeon-crawler.component.ts` keeps only `walls`/`torches`) and `animateQuestIndicator` looks the board up by `scene.getObjectByName("questBoard")`, so gameplay is not broken. The collision wall is also missing from `camp.walls` until the callback fires, so the player can walk through the board for a frame (or forever if the GLB never loads). Fix: return a `THREE.Group` placeholder synchronously, parent the loaded model into it, and push the collision mesh before returning — or make `createCamp` async. Characterization: `camp.create.spec.ts` — "returns a null questBoard handle when GLB load stays pending (async gap)".
spikerj commented 2026-08-14 03:14:37 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). createQuestBoard returns a live Group before the async GLB load. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). createQuestBoard returns a live Group before the async GLB load. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1028