spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Our Stack: containers-mode hex labels never appear even when Labels is on #1029

New Issue
Closed
opened 2026-08-13 04:44:21 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 04:44:21 +00:00
Owner
Copy link
Copy source

Wave 7 coverage (agent a4) found that DreamstreamClusterDashboardComponent.updateLabelVisibility only treats cpu / ram / storage as label-eligible modes:

const shouldShowLabels = (mode === "cpu" || mode === "ram" || mode === "storage") && this.showLabels();

updateLabelText already has a containers branch that would show a {count} ctr label on coreIndex-0 per node (and the method comment on updateLabelVisibility explicitly lists storage/containers as coreIndex-0-only modes). Because containers is missing from shouldShowLabels, toggling Labels on while in containers mode still calls hideAllLabels() and the per-node instance counts never appear on the polygon.

Fix: include mode === "containers" in shouldShowLabels.

Characterization test lives in dreamstream-cluster-dashboard.logic.spec.ts (wave 7 a4).

Wave 7 coverage (agent a4) found that `DreamstreamClusterDashboardComponent.updateLabelVisibility` only treats `cpu` / `ram` / `storage` as label-eligible modes: ```ts const shouldShowLabels = (mode === "cpu" || mode === "ram" || mode === "storage") && this.showLabels(); ``` `updateLabelText` already has a `containers` branch that would show a `{count} ctr` label on coreIndex-0 per node (and the method comment on `updateLabelVisibility` explicitly lists storage/containers as coreIndex-0-only modes). Because `containers` is missing from `shouldShowLabels`, toggling Labels on while in containers mode still calls `hideAllLabels()` and the per-node instance counts never appear on the polygon. Fix: include `mode === "containers"` in `shouldShowLabels`. Characterization test lives in `dreamstream-cluster-dashboard.logic.spec.ts` (wave 7 a4).
spikerj commented 2026-08-14 04:25:00 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1029