spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

space-game: default Shift boost never matches because shiftKey is treated as a modifier #1032

New Issue
Closed
opened 2026-08-13 04:48:14 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 04:48:14 +00:00
Owner
Copy link
Copy source

Default boost binding is currentKey: "Shift" with no modifiers. onKeyDown always passes shift: event.shiftKey, and a Shift keydown has shiftKey === true. KeybindingManager.matchesKeybinding then rejects the press because !!modifiers.shift !== !!kbMods.shift.

Result: the default Shift boost never engages (or releases) through the real keyboard path.

Repro: space-game, press Shift — isBoostActive stays false.

Fix options:

  • Store modifiers: { shift: true } on the boost binding, or
  • When the bound key itself is Shift/Control/Alt/Meta, do not treat that key's own modifier bit as an extra required modifier.

Caught by space-game.component.logic.spec.ts (Wave 7 a2).

Default boost binding is `currentKey: "Shift"` with no `modifiers`. `onKeyDown` always passes `shift: event.shiftKey`, and a Shift keydown has `shiftKey === true`. `KeybindingManager.matchesKeybinding` then rejects the press because `!!modifiers.shift !== !!kbMods.shift`. Result: the default Shift boost never engages (or releases) through the real keyboard path. Repro: space-game, press Shift — `isBoostActive` stays false. Fix options: - Store `modifiers: { shift: true }` on the boost binding, or - When the bound key itself is Shift/Control/Alt/Meta, do not treat that key's own modifier bit as an extra required modifier. Caught by `space-game.component.logic.spec.ts` (Wave 7 a2).
spikerj commented 2026-08-14 04:25:00 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1032