spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

ThrusterInstanceManager.unregisterSpacecraft never reclaims instance slots #1033

New Issue
Closed
opened 2026-08-13 05:02:46 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:02:46 +00:00
Owner
Copy link
Copy source

Discovered while writing characterization tests for projects/spikersoft/src/app/_components/_games/space-game/spacecraft/thruster-instance-manager.ts (wave 7 coverage).

What happens

registerSpacecraft advances nextInstanceIndex by the thruster count. unregisterSpacecraft hides those instances (scale-0 matrix + zeroed thrusterStates) and deletes the registration, but does not decrement nextInstanceIndex or recycle the freed range.

A spacecraft that despawns and respawns therefore consumes a new block of the 24×N InstancedMesh pool. After enough spawn/despawn cycles the manager hits Out of instance capacity even though no live spacecraft occupy the earlier slots.

Repro (characterization, already pinned)

  1. getInstance(1) → 24 slots.
  2. registerSpacecraft(1, …) → indices [0].
  3. unregisterSpacecraft(1).
  4. registerSpacecraft(1, …) again → indices [1], not [0].

Expected

Unregister should return the range to a free list (or compact nextInstanceIndex) so a re-register reuses the old indices.

Pinned as a characterization test in thruster-instance-manager.spec.ts so the suite stays green until this is fixed.

Discovered while writing characterization tests for `projects/spikersoft/src/app/_components/_games/space-game/spacecraft/thruster-instance-manager.ts` (wave 7 coverage). ## What happens `registerSpacecraft` advances `nextInstanceIndex` by the thruster count. `unregisterSpacecraft` hides those instances (scale-0 matrix + zeroed `thrusterStates`) and deletes the registration, but **does not decrement `nextInstanceIndex` or recycle the freed range**. A spacecraft that despawns and respawns therefore consumes a *new* block of the 24×N InstancedMesh pool. After enough spawn/despawn cycles the manager hits `Out of instance capacity` even though no live spacecraft occupy the earlier slots. ## Repro (characterization, already pinned) 1. `getInstance(1)` → 24 slots. 2. `registerSpacecraft(1, …)` → indices `[0]`. 3. `unregisterSpacecraft(1)`. 4. `registerSpacecraft(1, …)` again → indices `[1]`, not `[0]`. ## Expected Unregister should return the range to a free list (or compact `nextInstanceIndex`) so a re-register reuses the old indices. Pinned as a characterization test in `thruster-instance-manager.spec.ts` so the suite stays green until this is fixed.
spikerj commented 2026-08-14 04:24:36 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1033