spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Dungeon crawler: server-mode HP/MP potions never dispatch when a stack is equipped #1038

New Issue
Closed
opened 2026-08-13 05:06:39 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:06:39 +00:00
Owner
Copy link
Copy source

DungeonCrawlerComponent.dispatchPotionUseToServer (used by useHPPotion / useMPPotion when useServerAuthority is true) looks up the bag slot with:

const targetId = equipped?.id ?? (kind === "hp" ? "healthPotion" : "manaPotion");
const slot = this.inventory.findIndex((it) => it?.itemId === targetId);

Two failures:

  1. When a potion is equipped, targetId is the instance uuid (equipped.id) compared against itemId ("healthPotion") — never matches.
  2. equipItem already removed the stack from the bag, so even a correct id/itemId lookup would miss.

Result: pressing 1/2 in server mode with an equipped potion never calls gameServer.useItem. Characterized in dungeon-crawler.inventory-maze.spec.ts (wave 7 a1 tick 2).

Expected: send the equipped potion's inventory slot (or re-find by itemId / keep a server slot index) so the server can consume the stack.

`DungeonCrawlerComponent.dispatchPotionUseToServer` (used by `useHPPotion` / `useMPPotion` when `useServerAuthority` is true) looks up the bag slot with: ```ts const targetId = equipped?.id ?? (kind === "hp" ? "healthPotion" : "manaPotion"); const slot = this.inventory.findIndex((it) => it?.itemId === targetId); ``` Two failures: 1. When a potion is equipped, `targetId` is the **instance uuid** (`equipped.id`) compared against `itemId` (`"healthPotion"`) — never matches. 2. `equipItem` already removed the stack from the bag, so even a correct `id`/`itemId` lookup would miss. Result: pressing 1/2 in server mode with an equipped potion never calls `gameServer.useItem`. Characterized in `dungeon-crawler.inventory-maze.spec.ts` (wave 7 a1 tick 2). Expected: send the equipped potion's inventory slot (or re-find by `itemId` / keep a server slot index) so the server can consume the stack.
spikerj commented 2026-08-14 03:44:02 +00:00
Author
Owner
Copy link
Copy source

Already present on spikersoft-angular master (48e93a23e). dispatchPotionUseToServer matches equipped.itemId (not the instance uuid) against bag slots. Closing.

Already present on `spikersoft-angular` `master` (`48e93a23e`). `dispatchPotionUseToServer` matches `equipped.itemId` (not the instance uuid) against bag slots. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1038