spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Dungeon crawler: exit-portal prompt uses a hardcoded 3-key gate instead of requiredKeys #1039

New Issue
Closed
opened 2026-08-13 05:06:39 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:06:39 +00:00
Owner
Copy link
Copy source

updateExitPortalPrompt shows the finish prompt when the player is near the portal and keysCollected() >= 3 (hardcoded). tryEnterExitPortal / checkExitCollision correctly gate on this.requiredKeys.

If requiredKeys is not 3, the HUD can claim the portal is ready while E does nothing (or hide the prompt when extra keys are required). Characterized in dungeon-crawler.quest-skill.spec.ts (wave 7 a1 tick 2).

const shouldShow = distSq < interactionDistSq && this.keysCollected() >= 3;

Expected: compare against this.requiredKeys (same contract as enter/collision).

`updateExitPortalPrompt` shows the finish prompt when the player is near the portal **and** `keysCollected() >= 3` (hardcoded). `tryEnterExitPortal` / `checkExitCollision` correctly gate on `this.requiredKeys`. If `requiredKeys` is not 3, the HUD can claim the portal is ready while E does nothing (or hide the prompt when extra keys are required). Characterized in `dungeon-crawler.quest-skill.spec.ts` (wave 7 a1 tick 2). ```ts const shouldShow = distSq < interactionDistSq && this.keysCollected() >= 3; ``` Expected: compare against `this.requiredKeys` (same contract as enter/collision).
spikerj commented 2026-08-14 03:44:02 +00:00
Author
Owner
Copy link
Copy source

Already present on spikersoft-angular master (48e93a23e). updateExitPortalPrompt gates on this.keysCollected() >= this.requiredKeys. Closing.

Already present on `spikersoft-angular` `master` (`48e93a23e`). `updateExitPortalPrompt` gates on `this.keysCollected() >= this.requiredKeys`. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1039