spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Art asset viewer PBR debug replaces multi-material meshes with a single swap #1040

New Issue
Closed
opened 2026-08-13 05:07:17 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:07:17 +00:00
Owner
Copy link
Copy source

In ArtAssetViewerComponent.setChannel, a mesh whose material is an array (multi-material GLB) stores the whole array in originalMaterials, then assigns mesh.material = swap using only original[0] as the source map.

During a non-lit PBR debug channel the second (and later) materials disappear; lit restores the array so the bug is easy to miss after toggling back. A characterization test in art-asset-viewer.component.spec.ts pins the restore path; the swap still collapses the array.

Expected: each material slot gets its own channel swap (or the debug view keeps the array length).

Source: libraries/features/art-studio/src/lib/art-asset-viewer/art-asset-viewer.component.ts (setChannel / channelMaterial).

In `ArtAssetViewerComponent.setChannel`, a mesh whose `material` is an array (multi-material GLB) stores the whole array in `originalMaterials`, then assigns `mesh.material = swap` using only `original[0]` as the source map. During a non-lit PBR debug channel the second (and later) materials disappear; `lit` restores the array so the bug is easy to miss after toggling back. A characterization test in `art-asset-viewer.component.spec.ts` pins the restore path; the swap still collapses the array. Expected: each material slot gets its own channel swap (or the debug view keeps the array length). Source: `libraries/features/art-studio/src/lib/art-asset-viewer/art-asset-viewer.component.ts` (`setChannel` / `channelMaterial`).
spikerj commented 2026-08-14 04:25:04 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1040