spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

SQL Data Sources pane does not expand a table when a column token is highlighted #1046

New Issue
Closed
opened 2026-08-13 05:24:40 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:24:40 +00:00
Owner
Copy link
Copy source

In SqlDataSourcesPaneComponent, <details [open]="section.open || isTableHighlighted(table.name)"> only auto-opens when the hovered keyword matches the table name.

Hovering a column chip in the lesson pane (e.g. first_name) sets highlightedToken to that column. isColumnHighlighted lights the row, but the parent <details> stays collapsed, so the highlight (and scrollIntoView) is off-screen until the student opens the section by hand.

Expected: a matching column token should open its parent table section the same way a table-name token does (isTableHighlighted(table.name) || table.columns.some(c => isColumnHighlighted(c.name))).

Pinned as a characterization test in sql-data-sources-pane.render.spec.ts (wave 7).

In `SqlDataSourcesPaneComponent`, `<details [open]="section.open || isTableHighlighted(table.name)">` only auto-opens when the hovered keyword matches the **table** name. Hovering a **column** chip in the lesson pane (e.g. `first_name`) sets `highlightedToken` to that column. `isColumnHighlighted` lights the row, but the parent `<details>` stays collapsed, so the highlight (and `scrollIntoView`) is off-screen until the student opens the section by hand. Expected: a matching column token should open its parent table section the same way a table-name token does (`isTableHighlighted(table.name) || table.columns.some(c => isColumnHighlighted(c.name))`). Pinned as a characterization test in `sql-data-sources-pane.render.spec.ts` (wave 7).
spikerj commented 2026-08-14 03:14:30 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). SQL Data Sources pane expands a table when a column token is highlighted. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). SQL Data Sources pane expands a table when a column token is highlighted. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1046