spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Profile menu-bar name ignores lastName and empty firstName #1049

New Issue
Closed
opened 2026-08-13 05:28:42 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:28:42 +00:00
Owner
Copy link
Copy source

ProfileService.notifyNameChanged(firstName, lastName?) takes lastName but never uses it:

this.userDisplayName.set(firstName || "Account");

Empty string also collapses to "Account". The menu-bar signal therefore never shows a surname, and a caller that passes ("", "Lovelace") looks logged-out.

Pinned by profile.service.http.spec.ts ("notifyNameChanged ignores lastName and falls back to Account").

`ProfileService.notifyNameChanged(firstName, lastName?)` takes `lastName` but never uses it: ```ts this.userDisplayName.set(firstName || "Account"); ``` Empty string also collapses to `"Account"`. The menu-bar signal therefore never shows a surname, and a caller that passes `("", "Lovelace")` looks logged-out. Pinned by `profile.service.http.spec.ts` ("notifyNameChanged ignores lastName and falls back to Account").
spikerj commented 2026-08-14 03:14:26 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). Profile menu-bar name uses lastName and an empty-firstName fallback. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). Profile menu-bar name uses lastName and an empty-firstName fallback. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1049