spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

RouteStorageService.generateId is dead — saveRoute never assigns missing ids #1050

New Issue
Closed
opened 2026-08-13 05:29:25 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:29:25 +00:00
Owner
Copy link
Copy source

RouteStorageService declares a private generateId() (route_ + timestamp + random suffix) but never calls it. saveRoute writes whatever route.id the caller passed; the object store is keyed on id.

Would catch: a GPS recording that forgot to stamp id would hit IndexedDB DataError on put instead of receiving a generated key. The unit suite reaches generateId only via bracket access — production saveRoute still ignores it.

Suggested fix: if !route.id, assign this.generateId() before store.put.

`RouteStorageService` declares a private `generateId()` (`route_` + timestamp + random suffix) but **never calls it**. `saveRoute` writes whatever `route.id` the caller passed; the object store is keyed on `id`. Would catch: a GPS recording that forgot to stamp `id` would hit IndexedDB `DataError` on `put` instead of receiving a generated key. The unit suite reaches `generateId` only via bracket access — production `saveRoute` still ignores it. Suggested fix: if `!route.id`, assign `this.generateId()` before `store.put`.
spikerj commented 2026-08-14 03:14:27 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). saveRoute assigns missing ids via generateId. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). saveRoute assigns missing ids via generateId. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1050