Floating XP/gold text does not round amounts (damage does) #1052

New Issue

2026-08-13T05:38:32Z

spikerj commented

2026-08-13 05:38:32 +00:00

createDamageText / createPlayerDamageText render -${Math.round(damage)}, but createExperienceText and createGoldText interpolate the raw number:

XP: `+${exp} XP`
gold: `+${gold} G`

A fractional grant (e.g. 10.6 XP or 3.25 gold from a scaled drop) therefore paints +10.6 XP / +3.25 G while damage for the same tick would show a whole number. The original game.js port this file claims to match rounded the combat number; XP/gold were left unrounded in the TypeScript port.

Fix: Math.round (or Math.floor if the economy is integer-only) on both XP and gold labels so HUD text cannot show fractions the rest of the combat UI never does.

Found by Wave 7 coverage tests (floating-text-system.leftovers.spec.ts).

`createDamageText` / `createPlayerDamageText` render `-${Math.round(damage)}`, but `createExperienceText` and `createGoldText` interpolate the raw number: - XP: `` `+${exp} XP` `` - gold: `` `+${gold} G` `` A fractional grant (e.g. 10.6 XP or 3.25 gold from a scaled drop) therefore paints `+10.6 XP` / `+3.25 G` while damage for the same tick would show a whole number. The original `game.js` port this file claims to match rounded the combat number; XP/gold were left unrounded in the TypeScript port. Fix: `Math.round` (or `Math.floor` if the economy is integer-only) on both XP and gold labels so HUD text cannot show fractions the rest of the combat UI never does. Found by Wave 7 coverage tests (`floating-text-system.leftovers.spec.ts`).

spikerj commented

2026-08-14 03:14:30 +00:00

Resolved in spikersoft-angular PR #819 (merged to master). Floating XP/gold text rounds amounts the same way damage does. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). Floating XP/gold text rounds amounts the same way damage does. Closing.

spikerj closed this issue

2026-08-14 03:14:30 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1052