spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

QuickType saveData catch hardcodes English instead of failedToSave i18n #1055

New Issue
Closed
opened 2026-08-13 05:44:02 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:44:02 +00:00
Owner
Copy link
Copy source

QuickTypeService.saveData catch builds:

`Failed to save QuickType data: ${error instanceof Error ? error.message : "Unknown error"}`

devTools.quickTypeRuntime.failedToSave already exists (Failed to save QuickType data: {{message}}), and errorMessage() already maps non-Errors through devTools.common.unknownError. Load/clear use those; save does not.

A Spanish (or any non-en) session therefore gets an English save failure while load/clear are translated. Non-Error throws also skip the shared unknown-error key.

Fix: this.t("devTools.quickTypeRuntime.failedToSave", { message: this.errorMessage(error) }) like failedToLoad / failedToClear.

Found by Wave 7 coverage (quick-type.service.leftovers.spec.ts).

`QuickTypeService.saveData` catch builds: ``` `Failed to save QuickType data: ${error instanceof Error ? error.message : "Unknown error"}` ``` `devTools.quickTypeRuntime.failedToSave` already exists (`Failed to save QuickType data: {{message}}`), and `errorMessage()` already maps non-Errors through `devTools.common.unknownError`. Load/clear use those; save does not. A Spanish (or any non-en) session therefore gets an English save failure while load/clear are translated. Non-Error throws also skip the shared unknown-error key. Fix: `this.t("devTools.quickTypeRuntime.failedToSave", { message: this.errorMessage(error) })` like `failedToLoad` / `failedToClear`. Found by Wave 7 coverage (`quick-type.service.leftovers.spec.ts`).
spikerj commented 2026-08-14 03:14:28 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). QuickType saveData uses the failedToSave i18n key. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). QuickType saveData uses the failedToSave i18n key. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1055