spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

quicktypeJSONSchema does not persist generated code (JSON path does) #1056

New Issue
Closed
opened 2026-08-13 05:44:02 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:44:02 +00:00
Owner
Copy link
Copy source

quicktypeJSON persists generatedCode / language / type name via saveData. quicktypeJSONSchema returns the SerializedRenderResult and does not call saveData.

Both live under the same "QUICKTYPE CORE METHODS (Enhanced with persistence)" section. A student who converts from JSON Schema then refreshes (or loadFromStorage) loses the generated types, while the JSON-sample path survives. The component cannot recover the last schema conversion from getCurrentData().

Fix: persist the same fields after a successful schema conversion (rawJson can be the schema string, or a dedicated field if schema vs sample must stay distinct).

Found by Wave 7 coverage (quick-type.service.leftovers.spec.ts).

`quicktypeJSON` persists `generatedCode` / language / type name via `saveData`. `quicktypeJSONSchema` returns the `SerializedRenderResult` and does **not** call `saveData`. Both live under the same "QUICKTYPE CORE METHODS (Enhanced with persistence)" section. A student who converts from JSON Schema then refreshes (or `loadFromStorage`) loses the generated types, while the JSON-sample path survives. The component cannot recover the last schema conversion from `getCurrentData()`. Fix: persist the same fields after a successful schema conversion (rawJson can be the schema string, or a dedicated field if schema vs sample must stay distinct). Found by Wave 7 coverage (`quick-type.service.leftovers.spec.ts`).
spikerj commented 2026-08-14 03:14:28 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). quicktypeJSONSchema persists generated code the same way the JSON path does. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). quicktypeJSONSchema persists generated code the same way the JSON path does. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1056