spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Art asset viewer WebGL failure blanks the 2D image overlay #1057

New Issue
Closed
opened 2026-08-13 05:45:17 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 05:45:17 +00:00
Owner
Copy link
Copy source

ArtAssetViewerComponent.initThree() constructs THREE.WebGLRenderer with no try/catch. The constructor effect calls it the moment #canvasContainer materializes (inside *transloco).

If WebGL is unavailable (blocked context, software GL fail, or a 2D-only session showing concept/texture overlays), the throw escapes the effect. detectChanges aborts, so the image overlay (imageSrc / download-original / close) never renders — users cannot even view the AVIF preview that does not need a GPU.

Pinned by art-asset-viewer.leftovers.spec.ts: overlay tests have to stub initThree, otherwise detectChanges throws THREE.WebGLRenderer: Error creating WebGL context before the overlay DOM exists.

Fix: catch the WebGL constructor failure, emit loadError, and still render the 2D overlay/toolbar.

ArtAssetViewerComponent.initThree() constructs THREE.WebGLRenderer with no try/catch. The constructor effect calls it the moment #canvasContainer materializes (inside *transloco). If WebGL is unavailable (blocked context, software GL fail, or a 2D-only session showing concept/texture overlays), the throw escapes the effect. detectChanges aborts, so the image overlay (imageSrc / download-original / close) never renders — users cannot even view the AVIF preview that does not need a GPU. Pinned by art-asset-viewer.leftovers.spec.ts: overlay tests have to stub initThree, otherwise detectChanges throws `THREE.WebGLRenderer: Error creating WebGL context` before the overlay DOM exists. Fix: catch the WebGL constructor failure, emit loadError, and still render the 2D overlay/toolbar.
spikerj commented 2026-08-14 03:14:25 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). Art asset viewer keeps the 2D overlay when WebGL fails. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). Art asset viewer keeps the 2D overlay when WebGL fails. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1057