spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

SQL grader empty result set shows a Transloco key instead of "(no result set)" #1061

New Issue
Closed
opened 2026-08-13 06:00:35 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 06:00:35 +00:00
Owner
Copy link
Copy source

Discovered while covering SqlLessonGraderService leftovers (wave 7 tick 5 a8).

gradeSubmission / runSandbox pass renderOutput a translator that already prefixes output.:

(key, params) => this.translateGrading(`output.${key}`, params)

but renderOutput asks for "output.noResultSet":

if (result.columns.length === 0) return tr?.("output.noResultSet") ?? "(no result set)";

That looks up devTools.sqlRunner.grading.output.output.noResultSet (missing). The real string lives at devTools.sqlRunner.grading.output.noResultSet = "(no result set)".

User-visible: a query that returns no result set prints the raw key devTools.sqlRunner.grading.output.output.noResultSet in the output pane instead of (no result set).

Fix is one of: tr?.("noResultSet") in renderOutput, or stop prefixing output. in the grader callback. Characterization test pins current behavior.

Discovered while covering `SqlLessonGraderService` leftovers (wave 7 tick 5 a8). `gradeSubmission` / `runSandbox` pass `renderOutput` a translator that already prefixes `output.`: ```ts (key, params) => this.translateGrading(`output.${key}`, params) ``` but `renderOutput` asks for `"output.noResultSet"`: ```ts if (result.columns.length === 0) return tr?.("output.noResultSet") ?? "(no result set)"; ``` That looks up `devTools.sqlRunner.grading.output.output.noResultSet` (missing). The real string lives at `devTools.sqlRunner.grading.output.noResultSet` = `"(no result set)"`. **User-visible:** a query that returns no result set prints the raw key `devTools.sqlRunner.grading.output.output.noResultSet` in the output pane instead of `(no result set)`. Fix is one of: `tr?.("noResultSet")` in `renderOutput`, or stop prefixing `output.` in the grader callback. Characterization test pins current behavior.
spikerj commented 2026-08-14 03:14:26 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). SQL grader empty result set shows "(no result set)" instead of a Transloco key. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). SQL grader empty result set shows "(no result set)" instead of a Transloco key. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1061