spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

MarksRouteService leaves a stale route when Directions returns no result #1063

New Issue
Closed
opened 2026-08-13 06:02:11 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 06:02:11 +00:00
Owner
Copy link
Copy source

Wave 7 tick 5 a3 coverage of MarksRouteService.calculateRoute.

Where: projects/spikersoft/src/app/_services/marks-site/marks-map/marks-route.service.ts

What: After a successful calculateRoute(), a later call whose Directions observable emits { result: undefined } (no throw) does not clear directionsResults$ and does not call setShowDirections(false). The previous polyline stays on the map with no error dialog.

The thrown-error path correctly shows messageDialog.error(...) and skips the cache. The empty-result path is silent.

Would have caught: subscribe handler if (result) { set; show } with no else to hide/clear.

Repro (unit): seed a successful result, then mock MapDirectionsService.route to of({ result: undefined }) and call calculateRoute() again — cached result is still the first route.

Wave 7 tick 5 a3 coverage of `MarksRouteService.calculateRoute`. **Where:** `projects/spikersoft/src/app/_services/marks-site/marks-map/marks-route.service.ts` **What:** After a successful `calculateRoute()`, a later call whose Directions observable emits `{ result: undefined }` (no throw) does **not** clear `directionsResults$` and does **not** call `setShowDirections(false)`. The previous polyline stays on the map with no error dialog. The thrown-error path correctly shows `messageDialog.error(...)` and skips the cache. The empty-result path is silent. **Would have caught:** subscribe handler `if (result) { set; show } ` with no `else` to hide/clear. **Repro (unit):** seed a successful result, then mock `MapDirectionsService.route` to `of({ result: undefined })` and call `calculateRoute()` again — cached result is still the first route.
spikerj commented 2026-08-13 23:23:42 +00:00
Author
Owner
Copy link
Copy source

Already present on spikersoft-angular master. Empty Directions results call clearDirections(), so a failed follow-up route no longer leaves a stale polyline. Closing.

Already present on `spikersoft-angular` `master`. Empty Directions results call `clearDirections()`, so a failed follow-up route no longer leaves a stale polyline. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1063