spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Marks getCustomers refetches forever when the list is legitimately empty #1065

New Issue
Closed
opened 2026-08-13 06:02:47 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 06:02:47 +00:00
Owner
Copy link
Copy source

getCustomers() short-circuits to the in-memory resource only when cached.length > 0. A successfully loaded empty list ([]) takes the reload branch on every subsequent call, so a shop with zero customers (or a first sync that returned empty) hits /api/mark-wilson/customer again each time the UI asks.

hasValue() is already true; the length check treats "empty but settled" as "failed/unloaded". Use hasValue() (or a distinct uninitialized state) so a real empty list is served from memory like a non-empty one.

Repro: flush GET .../customer with [], call getCustomers() again — a second GET is issued.

Seen in projects/spikersoft/src/app/_services/marks-site/marks-customer/marks-customer.service.ts.

`getCustomers()` short-circuits to the in-memory resource only when `cached.length > 0`. A successfully loaded empty list (`[]`) takes the reload branch on every subsequent call, so a shop with zero customers (or a first sync that returned empty) hits `/api/mark-wilson/customer` again each time the UI asks. `hasValue()` is already true; the length check treats "empty but settled" as "failed/unloaded". Use `hasValue()` (or a distinct uninitialized state) so a real empty list is served from memory like a non-empty one. Repro: flush `GET .../customer` with `[]`, call `getCustomers()` again — a second GET is issued. Seen in `projects/spikersoft/src/app/_services/marks-site/marks-customer/marks-customer.service.ts`.
spikerj commented 2026-08-14 03:14:29 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). Marks getCustomers does not refetch forever when the list is legitimately empty. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). Marks getCustomers does not refetch forever when the list is legitimately empty. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1065