spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

JsStepDebuggerService: dropping the interpreter between runUntil batches leaves state=running #1067

New Issue
Closed
opened 2026-08-13 06:30:05 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 06:30:05 +00:00
Owner
Copy link
Copy source

Found while covering the remaining runUntil defensive arms (Wave 7 a7 tick 6).

runUntil's runBatch checks if (!this.interpreter) after a setTimeout(0) yield, calls finishRunUntil(), and returns without flipping _state off running.

Repro (characterization in js-step-debugger.rununtil-leftovers.spec.ts):

  1. prepare("while (true) {}") then runUntil(() => false) so the first batch yields.
  2. Null interpreter before the queued batch fires.
  3. The in-flight Promise resolves, but state() stays "running".

Expected: idle (or errored) with a cleared interpreter, matching stop(). Actual: running, so the toolbar can still show Pause/Step as if a session is live.

Related: #1058 (stop() from a native mid-step is overwritten to errored).

Found while covering the remaining `runUntil` defensive arms (Wave 7 a7 tick 6). `runUntil`'s `runBatch` checks `if (!this.interpreter)` after a `setTimeout(0)` yield, calls `finishRunUntil()`, and returns **without** flipping `_state` off `running`. Repro (characterization in `js-step-debugger.rununtil-leftovers.spec.ts`): 1. `prepare("while (true) {}")` then `runUntil(() => false)` so the first batch yields. 2. Null `interpreter` before the queued batch fires. 3. The in-flight Promise resolves, but `state()` stays `"running"`. Expected: `idle` (or `errored`) with a cleared interpreter, matching `stop()`. Actual: `running`, so the toolbar can still show Pause/Step as if a session is live. Related: #1058 (`stop()` from a native mid-step is overwritten to `errored`).
spikerj commented 2026-08-14 03:14:25 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). runUntil no longer leaves state=running when the interpreter is dropped between batches. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). runUntil no longer leaves state=running when the interpreter is dropped between batches. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1067