spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

RPG sendToQuickType uses required injector.get unlike SharedExport optional #1069

New Issue
Closed
opened 2026-08-13 06:33:03 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 06:33:03 +00:00
Owner
Copy link
Copy source

RpgGameComponent.sendToQuickType does:

const { QuickTypeService } = await import("@spikersoft/feature-dev-tools-quick-type");
const quickTypeService = this.injector.get(QuickTypeService);
await quickTypeService.quicktypeJSON(...);

SharedExportComponent.exportToQuickType uses injector.get(QuickTypeService, null, { optional: true }) and warns when the service is missing, still emitting quicktype_success.

If the lazy module loads but the token is not in this injector (or get() throws), RPG always shows the 5s error snackbar. SharedExport degrades. The RPG page already embeds app-shared-export, so the two paths disagree.

Pinned by rpg-game.component.logic.spec.ts (success requires providing QuickTypeService; reject arm snacks the error).

`RpgGameComponent.sendToQuickType` does: ``` const { QuickTypeService } = await import("@spikersoft/feature-dev-tools-quick-type"); const quickTypeService = this.injector.get(QuickTypeService); await quickTypeService.quicktypeJSON(...); ``` `SharedExportComponent.exportToQuickType` uses `injector.get(QuickTypeService, null, { optional: true })` and warns when the service is missing, still emitting `quicktype_success`. If the lazy module loads but the token is not in this injector (or `get()` throws), RPG always shows the 5s error snackbar. SharedExport degrades. The RPG page already embeds `app-shared-export`, so the two paths disagree. Pinned by `rpg-game.component.logic.spec.ts` (success requires providing `QuickTypeService`; reject arm snacks the error).
spikerj commented 2026-08-14 04:24:51 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1069