spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

dungeon keybinding HUD: Escape during conflict dialog is not consumed #1074

New Issue
Closed
opened 2026-08-13 13:30:25 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:30:25 +00:00
Owner
Copy link
Copy source

Dungeon KeybindingConfigHUD.handleKeyDown only captures keys while rebindingActionId is set. On a conflicting rebind the HUD clears that id, stores conflictActionId, and shows Swap/Cancel — but handleKeyDown then returns false for every key, including Escape.

The parent close handler can therefore dismiss the whole keybinding modal while the conflict dialog is still on screen. Space-game KeybindingConfigHUD swallows keys when its conflict dialog is visible; dungeon does not.

Repro (unit): enter rebind → onRebind returns { success: false, conflict } → handleKeyDown(Escape) is false.

Related cleanup: dismissing the dialog via Swap/Cancel leaves conflictSwapBtn / conflictCancelBtn pointing at detached meshes (parent === null). Harmless today because handleClick is gated on conflictActionId, but the pointers are only nulled in dispose().

File: projects/spikersoft/src/app/_components/_games/dungeon-crawler/hud/keybinding-config-hud.ts (handleKeyDown / handleConflictClick).

Dungeon `KeybindingConfigHUD.handleKeyDown` only captures keys while `rebindingActionId` is set. On a conflicting rebind the HUD clears that id, stores `conflictActionId`, and shows Swap/Cancel — but `handleKeyDown` then returns `false` for every key, including Escape. The parent close handler can therefore dismiss the whole keybinding modal while the conflict dialog is still on screen. Space-game `KeybindingConfigHUD` swallows keys when its conflict dialog is visible; dungeon does not. Repro (unit): enter rebind → `onRebind` returns `{ success: false, conflict }` → `handleKeyDown(Escape)` is `false`. Related cleanup: dismissing the dialog via Swap/Cancel leaves `conflictSwapBtn` / `conflictCancelBtn` pointing at detached meshes (`parent === null`). Harmless today because `handleClick` is gated on `conflictActionId`, but the pointers are only nulled in `dispose()`. File: `projects/spikersoft/src/app/_components/_games/dungeon-crawler/hud/keybinding-config-hud.ts` (`handleKeyDown` / `handleConflictClick`).
spikerj commented 2026-08-14 04:24:36 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1074