spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Dungeon crawler main-menu Settings is a no-op (showSettings TODO) #1075

New Issue
Closed
opened 2026-08-13 13:32:13 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:32:13 +00:00
Owner
Copy link
Copy source

Wave 8 coverage of initNativeHUD found that the native main-menu HUD wires action === "settings" to showSettings(), but showSettings() is an empty TODO and never opens the settings modal.

toggleSettings() already flips showSettingsModal. Toolbar Settings uses that path; the main menu does not.

Repro: boot dungeon crawler, click Settings on the main menu.
Expected: settings HUD/modal opens (showSettingsModal true).
Actual: no state change.

File: projects/spikersoft/src/app/_components/_games/dungeon-crawler/dungeon-crawler.component.ts (showSettings ~6339, mainMenuHUD.onAction "settings" branch ~2137).

Characterization test: dungeon-crawler.init-three.spec.ts ("leave settings inert").

Wave 8 coverage of `initNativeHUD` found that the native main-menu HUD wires `action === "settings"` to `showSettings()`, but `showSettings()` is an empty TODO and never opens the settings modal. `toggleSettings()` already flips `showSettingsModal`. Toolbar Settings uses that path; the main menu does not. **Repro:** boot dungeon crawler, click Settings on the main menu. **Expected:** settings HUD/modal opens (`showSettingsModal` true). **Actual:** no state change. File: `projects/spikersoft/src/app/_components/_games/dungeon-crawler/dungeon-crawler.component.ts` (`showSettings` ~6339, `mainMenuHUD.onAction` `"settings"` branch ~2137). Characterization test: `dungeon-crawler.init-three.spec.ts` ("leave settings inert").
spikerj commented 2026-08-14 04:25:05 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1075