spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

WeaponsHUD.render leaves autoClear=false when render() throws; dispose rebuilds #1076

New Issue
Closed
opened 2026-08-13 13:33:26 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:33:26 +00:00
Owner
Copy link
Copy source

WeaponsHUD.render sets renderer.autoClear = false, then clearDepth() + render(), then restores autoClear.

If renderer.render throws, the restore is skipped (it sits after render() inside the same try, and the catch only console.errors). Callers that share the renderer then draw the next pass with autoClear === false and leave uncleared colour buffers.

dispose() is also wrong: it calls rebuildUI() (which recreates the bar) and then drops the tracking arrays, so the group still has live meshes after dispose.

File: projects/spikersoft/src/app/_components/_games/space-game/hud/weapons-hud.ts (render / dispose).

`WeaponsHUD.render` sets `renderer.autoClear = false`, then `clearDepth()` + `render()`, then restores `autoClear`. If `renderer.render` throws, the restore is skipped (it sits after `render()` inside the same `try`, and the `catch` only `console.error`s). Callers that share the renderer then draw the next pass with `autoClear === false` and leave uncleared colour buffers. `dispose()` is also wrong: it calls `rebuildUI()` (which *recreates* the bar) and then drops the tracking arrays, so the group still has live meshes after dispose. File: `projects/spikersoft/src/app/_components/_games/space-game/hud/weapons-hud.ts` (`render` / `dispose`).
spikerj commented 2026-08-14 03:14:36 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). WeaponsHUD restores autoClear in finally; dispose tears down instead of rebuilding. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). WeaponsHUD restores autoClear in finally; dispose tears down instead of rebuilding. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1076