spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

NameModalHUD language change wipes the typed player name #1077

New Issue
Closed
opened 2026-08-13 13:33:31 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:33:31 +00:00
Owner
Copy link
Copy source

While covering NameModalHUD (Wave 8 a5, tests only) the language-change paths were compared to resize().

What happens: setLanguage() (called every frame from updateModalHUDs when the code actually changes) and the language hit-mesh in handleClick both do clearGroup() + buildUI() without saving the live HUDTextInput value. buildUI() disposes the old input and constructs a new empty one. resize() already avoids this with _restoreName.

User-visible: typing a name, then clicking the language row (or a parent calling setLanguage("es")) clears the field and greys Confirm. The per-frame idempotent guard stops 60 Hz rebuilds, but a real en↔es change still wipes the name.

Fix: capture this.nameInput?.getValue() into _restoreName before dispose/rebuild in setLanguage and the language-click branch, the same way resize does.

Repro (jsdom): new NameModalHUD(800,600); hud.setPlayerName("Ada"); hud.setLanguage("es"); → getPlayerName() is "".

File: projects/spikersoft/src/app/_components/_games/dungeon-crawler/hud/name-modal-hud.ts

While covering `NameModalHUD` (Wave 8 a5, tests only) the language-change paths were compared to `resize()`. **What happens:** `setLanguage()` (called every frame from `updateModalHUDs` when the code actually changes) and the language hit-mesh in `handleClick` both do `clearGroup()` + `buildUI()` without saving the live `HUDTextInput` value. `buildUI()` disposes the old input and constructs a new empty one. `resize()` already avoids this with `_restoreName`. **User-visible:** typing a name, then clicking the language row (or a parent calling `setLanguage("es")`) clears the field and greys Confirm. The per-frame idempotent guard stops 60 Hz rebuilds, but a real en↔es change still wipes the name. **Fix:** capture `this.nameInput?.getValue()` into `_restoreName` before dispose/rebuild in `setLanguage` and the language-click branch, the same way `resize` does. **Repro (jsdom):** `new NameModalHUD(800,600); hud.setPlayerName("Ada"); hud.setLanguage("es");` → `getPlayerName()` is `""`. File: `projects/spikersoft/src/app/_components/_games/dungeon-crawler/hud/name-modal-hud.ts`
spikerj commented 2026-08-14 03:14:32 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). NameModalHUD language change keeps the typed player name. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). NameModalHUD language change keeps the typed player name. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1077