spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

space-game KeybindingConfigHUD: screen-centred dialogs ignore clicks after the panel is dragged #1078

New Issue
Closed
opened 2026-08-13 13:34:16 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:34:16 +00:00
Owner
Copy link
Copy source

Wave 8 coverage a3 (KeybindingConfigHUD in projects/spikersoft/src/app/_components/_games/space-game/hud/keybinding-config-hud.ts).

createConflictDialog / createBackendLoadDialog place the modal meshes at screen centre. handleClick however returns false immediately when the point is outside the 600×500 panel (isInBounds uses posX/posY).

Repro (unit, jsdom, mocked renderer — no GPU):

  1. setPosition(0, 0) (or title-bar drag the panel into a corner).
  2. showBackendLoadDialog() / showConflict(...).
  3. Click the Yes/No (or Swap) mesh centre.

Observed: handleClick returns false; onRebind is never called. The dialog is still visible at screen centre, outside the dragged panel.

Same class: clicks that hit the dialog background but miss the buttons also return false, so the parent can treat them as game clicks while a modal is up.

Expected: while a modal is visible, hit-test the dialog first (or consume every click). Do not require the panel AABB.

Covered by keybinding-config-hud.spec.ts (“dialog clicks miss when the panel has been dragged off the screen-centred modal”).

Wave 8 coverage a3 (`KeybindingConfigHUD` in `projects/spikersoft/src/app/_components/_games/space-game/hud/keybinding-config-hud.ts`). `createConflictDialog` / `createBackendLoadDialog` place the modal meshes at **screen centre**. `handleClick` however returns false immediately when the point is outside the 600×500 **panel** (`isInBounds` uses `posX`/`posY`). Repro (unit, jsdom, mocked renderer — no GPU): 1. `setPosition(0, 0)` (or title-bar drag the panel into a corner). 2. `showBackendLoadDialog()` / `showConflict(...)`. 3. Click the Yes/No (or Swap) mesh centre. Observed: `handleClick` returns `false`; `onRebind` is never called. The dialog is still visible at screen centre, outside the dragged panel. Same class: clicks that hit the dialog background but miss the buttons also return `false`, so the parent can treat them as game clicks while a modal is up. Expected: while a modal is visible, hit-test the dialog first (or consume every click). Do not require the panel AABB. Covered by `keybinding-config-hud.spec.ts` (“dialog clicks miss when the panel has been dragged off the screen-centred modal”).
spikerj commented 2026-08-14 04:24:51 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1078