spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

space-game KeybindingConfigHUD.dispose rebuilds the overlay instead of tearing it down #1079

New Issue
Closed
opened 2026-08-13 13:34:16 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:34:16 +00:00
Owner
Copy link
Copy source

Wave 8 coverage a3 (KeybindingConfigHUD.dispose in projects/spikersoft/src/app/_components/_games/space-game/hud/keybinding-config-hud.ts).

dispose() calls rebuildUI(), which:

  1. removes and disposes current children,
  2. recreates the full overlay (createUI() + updateKeybindingList()).

So ngOnDestroy / HUD teardown that calls dispose() leaves a brand-new troika Text + mesh graph attached to the scene instead of an empty group. Compare dungeon HUDs (clearGroup() then null hit targets) and ShipSelectionHUD (empty group after dispose).

Expected: dispose() should tear down and not rebuild. rebuildUI() is the right helper for resize(), not for dispose.

Covered by keybinding-config-hud.spec.ts (“dispose rebuilds the overlay instead of leaving an empty group”).

Wave 8 coverage a3 (`KeybindingConfigHUD.dispose` in `projects/spikersoft/src/app/_components/_games/space-game/hud/keybinding-config-hud.ts`). `dispose()` calls `rebuildUI()`, which: 1. removes and disposes current children, 2. **recreates** the full overlay (`createUI()` + `updateKeybindingList()`). So `ngOnDestroy` / HUD teardown that calls `dispose()` leaves a brand-new troika `Text` + mesh graph attached to the scene instead of an empty group. Compare dungeon HUDs (`clearGroup()` then null hit targets) and `ShipSelectionHUD` (empty group after dispose). Expected: `dispose()` should tear down and not rebuild. `rebuildUI()` is the right helper for `resize()`, not for dispose. Covered by `keybinding-config-hud.spec.ts` (“dispose rebuilds the overlay instead of leaving an empty group”).
spikerj commented 2026-08-14 03:14:36 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). KeybindingConfigHUD.dispose tears the overlay down instead of rebuilding it. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). KeybindingConfigHUD.dispose tears the overlay down instead of rebuilding it. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1079