spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

SkillBarHUD.setSlots([]) leaves stale drag AABB after clearing slots #1082

New Issue
Closed
opened 2026-08-13 13:53:36 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:53:36 +00:00
Owner
Copy link
Copy source

Where: projects/spikersoft/src/app/_components/_games/dungeon-crawler/hud/skill-bar-hud.ts — setSlots([]) → rebuildSlots().

What: After slots have been built, emptying the loadout calls clearGroup() then rebuildSlots(), which early-returns on count === 0 without resetting _bounds. The previous AABB (width = n*48+(n-1)*4, y = 80) is left in place. HUDPanel.handleDragMouseDown still hits that rectangle, so the player can drag an invisible skill bar.

Repro (unit): hud.setSlots([spell, spell]); hud.setSlots([]); → _bounds.width stays 100 and group.children.length is 0.

Expected: empty loadout should zero _bounds (and skip drag) the same way the constructor starts.

Found by Wave 8 a2 coverage tests.

**Where:** `projects/spikersoft/src/app/_components/_games/dungeon-crawler/hud/skill-bar-hud.ts` — `setSlots([])` → `rebuildSlots()`. **What:** After slots have been built, emptying the loadout calls `clearGroup()` then `rebuildSlots()`, which early-returns on `count === 0` without resetting `_bounds`. The previous AABB (`width = n*48+(n-1)*4`, `y = 80`) is left in place. `HUDPanel.handleDragMouseDown` still hits that rectangle, so the player can drag an invisible skill bar. **Repro (unit):** `hud.setSlots([spell, spell]); hud.setSlots([]);` → `_bounds.width` stays `100` and `group.children.length` is `0`. **Expected:** empty loadout should zero `_bounds` (and skip drag) the same way the constructor starts. Found by Wave 8 a2 coverage tests.
spikerj commented 2026-08-14 04:24:56 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1082