spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

space-game PeriodicTableHUD: DEFAULTS button is never hit-tested #1085

New Issue
Closed
opened 2026-08-13 13:54:41 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:54:41 +00:00
Owner
Copy link
Copy source

Wave 8 coverage a3 (PeriodicTableHUD in projects/spikersoft/src/app/_components/_games/space-game/hud/periodic-table-hud.ts).

createUI paints a 120×36 DEFAULTS rect next to CONFIRM (defaultX = confirmX - 130) but never stores the mesh, never sets userData.action, and handleClick never hit-tests it. selectDefaultElements() (Fe/Al/Si/Cu) is therefore unreachable from a click.

Repro (unit, jsdom, mocked troika / WebGLRenderer — no GPU):

  1. show().
  2. Click the DEFAULTS rect centre (the 120×36 mesh that is not userData.action === "confirm").

Observed: handleClick returns true (click consumed as a panel miss); getSelectedElements() stays []; onElementSelected is never called.

Expected: clicking DEFAULTS should run selectDefaultElements() (and typically refresh the selection callbacks / info text), matching the painted control.

Covered by periodic-table-hud.leftovers.spec.ts (“DEFAULTS button is painted but never hit-tested…”).

Wave 8 coverage a3 (`PeriodicTableHUD` in `projects/spikersoft/src/app/_components/_games/space-game/hud/periodic-table-hud.ts`). `createUI` paints a 120×36 DEFAULTS rect next to CONFIRM (`defaultX = confirmX - 130`) but never stores the mesh, never sets `userData.action`, and `handleClick` never hit-tests it. `selectDefaultElements()` (Fe/Al/Si/Cu) is therefore unreachable from a click. Repro (unit, jsdom, mocked troika / WebGLRenderer — no GPU): 1. `show()`. 2. Click the DEFAULTS rect centre (the 120×36 mesh that is not `userData.action === "confirm"`). Observed: `handleClick` returns `true` (click consumed as a panel miss); `getSelectedElements()` stays `[]`; `onElementSelected` is never called. Expected: clicking DEFAULTS should run `selectDefaultElements()` (and typically refresh the selection callbacks / info text), matching the painted control. Covered by `periodic-table-hud.leftovers.spec.ts` (“DEFAULTS button is painted but never hit-tested…”).
spikerj commented 2026-08-14 03:14:35 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). PeriodicTableHUD DEFAULTS button is hit-tested. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). PeriodicTableHUD DEFAULTS button is hit-tested. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1085