spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Dungeon GuideHUD.handleClick returns void so HUDScene never consumes prev/next clicks #1088

New Issue
Closed
opened 2026-08-13 13:55:14 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:55:14 +00:00
Owner
Copy link
Copy source

Summary

GuideHUD.handleClick is typed and implemented as void. HUDScene.handleClick only stops walking panels when the handler is truthy:

if ((entry.panel as any).handleClick?.(hudX, hudY, screenX, screenY)) {
  return true;
}

undefined is falsy, so even a successful Previous/Next click falls through to lower HUD panels (and does not consume the event). ShopHUD returns boolean and is consumed correctly; GuideHUD should do the same.

Disabled Previous also does not consume the click (canPrev is false → neither branch returns a consumed flag).

setStep has no equality guard, so updateModalHUDs rebuilds the overlay every frame while the guide is visible (C-7).

Files

  • projects/spikersoft/src/app/_components/_games/dungeon-crawler/hud/guide-hud.ts (handleClick, setStep)
  • libraries/game/gl-hud/src/lib/hud-scene.ts (handleClick)
## Summary `GuideHUD.handleClick` is typed and implemented as `void`. `HUDScene.handleClick` only stops walking panels when the handler is truthy: ```ts if ((entry.panel as any).handleClick?.(hudX, hudY, screenX, screenY)) { return true; } ``` `undefined` is falsy, so even a successful Previous/Next click falls through to lower HUD panels (and does not consume the event). ShopHUD returns `boolean` and is consumed correctly; GuideHUD should do the same. Disabled Previous also does not consume the click (`canPrev` is false → neither branch returns a consumed flag). `setStep` has no equality guard, so `updateModalHUDs` rebuilds the overlay every frame while the guide is visible (C-7). ## Files - `projects/spikersoft/src/app/_components/_games/dungeon-crawler/hud/guide-hud.ts` (`handleClick`, `setStep`) - `libraries/game/gl-hud/src/lib/hud-scene.ts` (`handleClick`)
spikerj commented 2026-08-14 03:14:33 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). GuideHUD.handleClick returns boolean so prev/next clicks are consumed. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). GuideHUD.handleClick returns boolean so prev/next clicks are consumed. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1088