spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

ToolbarHUD.dispose leaves btnMeshes so stale clicks still fire #1090

New Issue
Closed
opened 2026-08-13 13:55:59 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:55:59 +00:00
Owner
Copy link
Copy source

Found while adding Wave 8 leftover coverage for toolbar-hud.ts.

dispose() releases the texture cache and clearGroup()s, but does not null btnMeshes / keyTexts (CompletionHUD and HintHUD do clear their hit targets).

After dispose:

  • handleClick still AABB-hits the disposed button meshes and invokes onButtonClick (score/minimap/settings/etc. can toggle after teardown)
  • setHotkeys writes .text / .sync() onto disposed troika Texts
  • an in-flight TextureLoader.load callback still textureCache.sets and addIconMeshes onto the torn-down group; those textures are never disposed

Suggested fix: this.btnMeshes = []; this.keyTexts = []; this.onButtonClick = null; in dispose, and guard the load callback with a disposed flag (or compare textureCache membership after a clear).

Found while adding Wave 8 leftover coverage for `toolbar-hud.ts`. `dispose()` releases the texture cache and `clearGroup()`s, but does **not** null `btnMeshes` / `keyTexts` (CompletionHUD and HintHUD do clear their hit targets). After dispose: - `handleClick` still AABB-hits the disposed button meshes and invokes `onButtonClick` (score/minimap/settings/etc. can toggle after teardown) - `setHotkeys` writes `.text` / `.sync()` onto disposed troika Texts - an in-flight `TextureLoader.load` callback still `textureCache.set`s and `addIconMesh`es onto the torn-down group; those textures are never disposed Suggested fix: `this.btnMeshes = []; this.keyTexts = []; this.onButtonClick = null;` in `dispose`, and guard the load callback with a disposed flag (or compare `textureCache` membership after a clear).
spikerj commented 2026-08-14 03:14:37 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #819 (merged to master). ToolbarHUD.dispose clears btnMeshes so stale clicks cannot fire. Closing.

Resolved in spikersoft-angular [PR #819](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/819) (merged to `master`). ToolbarHUD.dispose clears btnMeshes so stale clicks cannot fire. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1090