spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Dungeon crawler: Shift keyup never restores walk speed after sprint #1092

New Issue
Closed
opened 2026-08-13 13:58:52 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 13:58:52 +00:00
Owner
Copy link
Copy source

Dungeon crawler onKeyUp lowercases the key (event.key.toLowerCase()), so releasing Shift becomes "shift".

DungeonKeybindingManager.normalizeKey only lowercases single-letter keys. For "Shift" / "shift" it returns the string unchanged, so matchesAction(..., "sprint") compares stored "Shift" against input "shift" and never matches.

Result: after sprinting, releasing Shift does not restore playerCurrentSpeed to playerBaseSpeed. The player stays at 1.5× walk speed until something else resets it.

Repro (unit): playerCurrentSpeed = 12, playerBaseSpeed = 6, onKeyUp({ key: "Shift" }) → speed stays 12. Rebinding sprint to "x" and releasing x restores 6 (the restore line is reachable).

Fix: either stop lowercasing before matchesAction, or make normalizeKey case-insensitive for named keys (Shift, Space, ArrowUp, F-keys).

Dungeon crawler `onKeyUp` lowercases the key (`event.key.toLowerCase()`), so releasing Shift becomes `"shift"`. `DungeonKeybindingManager.normalizeKey` only lowercases single-letter keys. For `"Shift"` / `"shift"` it returns the string unchanged, so `matchesAction(..., "sprint")` compares stored `"Shift"` against input `"shift"` and never matches. Result: after sprinting, releasing Shift does not restore `playerCurrentSpeed` to `playerBaseSpeed`. The player stays at 1.5× walk speed until something else resets it. Repro (unit): `playerCurrentSpeed = 12`, `playerBaseSpeed = 6`, `onKeyUp({ key: "Shift" })` → speed stays 12. Rebinding sprint to `"x"` and releasing `x` restores 6 (the restore line is reachable). Fix: either stop lowercasing before `matchesAction`, or make `normalizeKey` case-insensitive for named keys (`Shift`, `Space`, `ArrowUp`, F-keys).
spikerj commented 2026-08-14 04:25:06 +00:00
Author
Owner
Copy link
Copy source

Fixed in spikersoft-angular PR #823 (a0f0ccd9). Closing.

Fixed in `spikersoft-angular` [PR #823](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/823) (`a0f0ccd9`). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1092