terminal: core command returning false is reported as command not found #1101

New Issue

2026-08-13T14:40:36Z

spikerj commented

2026-08-13 14:40:36 +00:00

TerminalComponent.processLine() rewrites a core command's stdout:

if (stdout === false) {
  stdout = cmd + ": command not found\n";
}

clear returns "", so this arm is dead today. If a core command returns boolean false to signal failure, the user sees "command not found" instead of a failure message. Strict === false (not !stdout) is what keeps clear from being misreported — the false-rewrite itself is still the wrong error for a registered command.

Characterization: terminal.leftovers.spec.ts.

`TerminalComponent.processLine()` rewrites a core command's stdout: ```ts if (stdout === false) { stdout = cmd + ": command not found\n"; } ``` `clear` returns `""`, so this arm is dead today. If a core command returns boolean `false` to signal failure, the user sees **"command not found"** instead of a failure message. Strict `=== false` (not `!stdout`) is what keeps `clear` from being misreported — the false-rewrite itself is still the wrong error for a registered command. Characterization: `terminal.leftovers.spec.ts`.

spikerj referenced this issue from a commit

2026-08-13 20:16:54 +00:00

fix(terminal): unknown names don't throw; false is failure not not-found

spikerj commented

2026-08-13 21:54:47 +00:00

Resolved in spikersoft-angular PR #818 (merged to master). A registered command returning false prints "command failed" instead of "command not found". Closing.

Resolved in spikersoft-angular [PR #818](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/818) (merged to `master`). A registered command returning `false` prints "command failed" instead of "command not found". Closing.

spikerj closed this issue

2026-08-13 21:54:53 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1101