Calendar SignalR timeout catch is dead — startConnection never rethrows #1102

New Issue

2026-08-13T14:40:42Z

spikerj commented

2026-08-13 14:40:42 +00:00

In projects/spikersoft/src/app/_components/calendar/services/signalr.service.ts, attemptReconnect() schedules:

setTimeout(async () => {
  try {
    await this.startConnection();
  } catch (error) {
    console.error("Reconnection attempt failed:", error);
    this.attemptReconnect();
  }
}, this.reconnectDelay * this.reconnectAttempts);

startConnection() already catches hub.start() failures, sets disconnected state, calls attemptReconnect(), and does not rethrow. The timeout catch is therefore unreachable in production.

If a later change adds throw error inside startConnection's catch, this outer catch would double-schedule reconnect (once from startConnection, once from the timeout).

Fix: either rethrow from startConnection and drop the inner attemptReconnect(), or delete the timeout catch and rely on the inner one.

In `projects/spikersoft/src/app/_components/calendar/services/signalr.service.ts`, `attemptReconnect()` schedules: ```ts setTimeout(async () => { try { await this.startConnection(); } catch (error) { console.error("Reconnection attempt failed:", error); this.attemptReconnect(); } }, this.reconnectDelay * this.reconnectAttempts); ``` `startConnection()` already catches `hub.start()` failures, sets disconnected state, calls `attemptReconnect()`, and **does not rethrow**. The timeout `catch` is therefore unreachable in production. If a later change adds `throw error` inside `startConnection`'s catch, this outer catch would *double-schedule* reconnect (once from `startConnection`, once from the timeout). Fix: either rethrow from `startConnection` and drop the inner `attemptReconnect()`, or delete the timeout catch and rely on the inner one.

spikerj commented

2026-08-13 21:54:45 +00:00

Resolved in spikersoft-angular PR #818 (merged to master). Removed the dead SignalR timeout catch so reconnect is scheduled only from startConnection. Closing.

Resolved in spikersoft-angular [PR #818](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/818) (merged to `master`). Removed the dead SignalR timeout catch so reconnect is scheduled only from `startConnection`. Closing.

spikerj closed this issue

2026-08-13 21:54:51 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1102