spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

consult-ideas Begin/Examples CTAs do nothing; close FAB aria-label says “start introduction!” #1103

New Issue
Closed
opened 2026-08-13 14:42:31 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 14:42:31 +00:00
Owner
Copy link
Copy source

Found while covering leftover click bindings on consult-ideas.html (Wave 8 tick 4 a3).

Dead CTAs: the Begin and Examples buttons in the idea-validation pane have no (click) (or routerLink). Close is the only CTA that emits show(false). Learners who tap Begin/Examples get no navigation and the overlay stays open.

<button class="cta-button" mat-stroked-button>
  {{ t("consult.common.begin") }}
</button>
<button class="cta-button" mat-stroked-button>
  {{ t("consult.common.examples") }}
</button>

Mislabeled close FAB: consult.ideas.closeFab.ariaLabel is "start introduction!" and the tooltip is "start business intro" on a button whose only behavior is show.emit(false). Screen readers announce the opposite of Close.

Expected: Begin/Examples should start the consult flow / open examples, and the FAB should be labeled as Close (matching the Close CTA).

Characterization test: consult-ideas.html-leftovers.spec.ts asserts Begin/Examples clicks do not emit show.

Found while covering leftover click bindings on `consult-ideas.html` (Wave 8 tick 4 a3). **Dead CTAs:** the Begin and Examples buttons in the idea-validation pane have no `(click)` (or routerLink). Close is the only CTA that emits `show(false)`. Learners who tap Begin/Examples get no navigation and the overlay stays open. ```html <button class="cta-button" mat-stroked-button> {{ t("consult.common.begin") }} </button> <button class="cta-button" mat-stroked-button> {{ t("consult.common.examples") }} </button> ``` **Mislabeled close FAB:** `consult.ideas.closeFab.ariaLabel` is `"start introduction!"` and the tooltip is `"start business intro"` on a button whose only behavior is `show.emit(false)`. Screen readers announce the opposite of Close. **Expected:** Begin/Examples should start the consult flow / open examples, and the FAB should be labeled as Close (matching the Close CTA). Characterization test: `consult-ideas.html-leftovers.spec.ts` asserts Begin/Examples clicks do not emit `show`.
spikerj commented 2026-08-13 21:54:47 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #818 (merged to master). Begin routes to /contact, Examples to /consult, and the overlay FAB is labeled Close. Closing.

Resolved in spikersoft-angular [PR #818](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/818) (merged to `master`). Begin routes to `/contact`, Examples to `/consult`, and the overlay FAB is labeled Close. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1103