spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

marks-customer-list: row .selected never paints on click/keyboard select #1105

New Issue
Closed
opened 2026-08-13 14:44:11 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 14:44:11 +00:00
Owner
Copy link
Copy source

MarksCustomerListComponent paints [class.selected]="selectedCustomer?.customerId === customer.customerId", but selectCustomer() (click / Enter / Space) only calls mapState.toggleCustomerSelection and emits changed. selectedCustomer is written solely by editCustomer().

Result: keyboard or mouse selection ticks the checkbox (map state) while the row never gets .selected. The highlight only appears if something calls editCustomer, which the template never does (the edit button is a routerLink).

Characterization: marks-customer-list.html-leftovers.spec.ts.

`MarksCustomerListComponent` paints `[class.selected]="selectedCustomer?.customerId === customer.customerId"`, but `selectCustomer()` (click / Enter / Space) only calls `mapState.toggleCustomerSelection` and emits `changed`. `selectedCustomer` is written solely by `editCustomer()`. Result: keyboard or mouse selection ticks the checkbox (map state) while the row never gets `.selected`. The highlight only appears if something calls `editCustomer`, which the template never does (the edit button is a `routerLink`). Characterization: `marks-customer-list.html-leftovers.spec.ts`.
spikerj commented 2026-08-13 21:54:45 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #818 (merged to master). Row .selected now follows map-state checkbox selection so click/Enter/Space highlight the row. Closing.

Resolved in spikersoft-angular [PR #818](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/818) (merged to `master`). Row `.selected` now follows map-state checkbox selection so click/Enter/Space highlight the row. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1105