spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Blog create chip Enter/Space + removed double-calls removeEmbeddedLink #1107

New Issue
Closed
opened 2026-08-13 14:44:36 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-13 14:44:36 +00:00
Owner
Copy link
Copy source

blog-create.html binds three remove paths on each embedded-link chip:

<mat-chip-option
  (removed)="removeEmbeddedLink(i)"
  (keydown.enter)="removeEmbeddedLink(i)"
  (keydown.space)="removeEmbeddedLink(i)"
>
  <button matChipRemove ...></button>
</mat-chip-option>

i is captured from @for. Material's chip often emits removed after Enter/Space (and matChipRemove also emits removed). The second call uses the same index against the already-mutated array, so the next link is deleted too.

Repro: two chips; press Enter on the first → both URLs gone if removed also fires.

Fix: keep a single handler ((removed) only, or keyboard handlers that preventDefault/stopPropagation and do not also bind removed).

`blog-create.html` binds three remove paths on each embedded-link chip: ```html <mat-chip-option (removed)="removeEmbeddedLink(i)" (keydown.enter)="removeEmbeddedLink(i)" (keydown.space)="removeEmbeddedLink(i)" > <button matChipRemove ...></button> </mat-chip-option> ``` `i` is captured from `@for`. Material's chip often emits `removed` after Enter/Space (and `matChipRemove` also emits `removed`). The second call uses the same index against the already-mutated array, so the *next* link is deleted too. Repro: two chips; press Enter on the first → both URLs gone if `removed` also fires. Fix: keep a single handler (`(removed)` only, or keyboard handlers that `preventDefault`/`stopPropagation` and do not also bind `removed`).
spikerj commented 2026-08-13 21:54:44 +00:00
Author
Owner
Copy link
Copy source

Resolved in spikersoft-angular PR #818 (merged to master). Embedded-link chips use only (removed), so Enter/Space no longer double-deletes the next link. Closing.

Resolved in spikersoft-angular [PR #818](https://git.spikersoft.com/spikerj/spikersoft-angular/pulls/818) (merged to `master`). Embedded-link chips use only `(removed)`, so Enter/Space no longer double-deletes the next link. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1107