spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

[Angular] v86: ship the emulator from the npm package (copy step) or drop the unused v86 npm dependency #1173

New Issue
Open
opened 2026-10-02 04:44:19 +00:00 by spikerj · 0 comments
spikerj commented 2026-10-02 04:44:19 +00:00
Owner
Copy link
Copy source

Why

v86 is in package.json and gets bumped every refresh (0.5.462 → 0.5.46x now), but nothing uses node_modules/v86. The legacy-systems exhibit loads committed files projects/spikersoft/src/assets/v86/v86.js (Jul 22) and v86.wasm (Jul 25) via v86-image-url.ts (~L23-24). Bumps are no-ops; the emulator we ship has silently drifted from the dependency we declare. The catalogue header records Upstream: copy/v86@589487c.

Upstream since our copy: IA32_PAT MSR + CLFLUSH, ATA_CMD_READ_LOG_EXT (#1639), use_graphical_text release fix (#1640).

Options (pick one)

  1. Wire it: add an asset glob / copy script for node_modules/v86/build/{libv86.js,v86.wasm} into the v86 assets path (like the isomorphic-git UMD copy in projects/spikersoft/project.json ~L45-53), delete the committed binaries, keep js+wasm in lock-step automatically.
  2. Drop it: remove the npm dep and document the manual vendoring procedure in the v86 assets README.

Acceptance criteria

  • one source of truth for the emulator build
  • boot test of all catalogue entries, especially the 7 with prebuilt state snapshots (v86-catalogue.ts, initial_state in v86-emulator.component.ts ~L365) — snapshots are tied to the emulator build and are the likeliest to break
  • wasm-module-registry / offline cache entries still match

Size: S (+ boot testing).

Filed from the 2026-10-02 spikersoft-angular pnpm outdated changelog review.

## Why `v86` is in `package.json` and gets bumped every refresh (0.5.462 → 0.5.46x now), but **nothing uses `node_modules/v86`**. The legacy-systems exhibit loads committed files `projects/spikersoft/src/assets/v86/v86.js` (Jul 22) and `v86.wasm` (Jul 25) via `v86-image-url.ts` (~L23-24). Bumps are no-ops; the emulator we ship has silently drifted from the dependency we declare. The catalogue header records `Upstream: copy/v86@589487c`. Upstream since our copy: IA32_PAT MSR + CLFLUSH, ATA_CMD_READ_LOG_EXT (#1639), `use_graphical_text` release fix (#1640). ## Options (pick one) 1. **Wire it**: add an asset glob / copy script for `node_modules/v86/build/{libv86.js,v86.wasm}` into the v86 assets path (like the isomorphic-git UMD copy in `projects/spikersoft/project.json` ~L45-53), delete the committed binaries, keep js+wasm in lock-step automatically. 2. **Drop it**: remove the npm dep and document the manual vendoring procedure in the v86 assets README. ## Acceptance criteria - [ ] one source of truth for the emulator build - [ ] **boot test** of all catalogue entries, especially the 7 with prebuilt `state` snapshots (`v86-catalogue.ts`, `initial_state` in `v86-emulator.component.ts` ~L365) — snapshots are tied to the emulator build and are the likeliest to break - [ ] wasm-module-registry / offline cache entries still match Size: **S** (+ boot testing). --- _Filed from the 2026-10-02 spikersoft-angular `pnpm outdated` changelog review._
spikerj added the enhancement label 2026-10-02 04:44:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1173