spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

[Bug] page-tour registry spec red on master: 8 /finance routes from #1415 have no page tour #1177

New Issue
Open
opened 2026-10-02 08:46:00 +00:00 by spikerj · 0 comments
spikerj commented 2026-10-02 08:46:00 +00:00
Owner
Copy link
Copy source

Bug

page-tour.registry.spec.ts › maps every dock-bearing route to an overview fails on master since the finance-user merge (spikersoft-angular#1415):

AssertionError: expected [ 'finance', 'finance/ledger', …(6) ] to deeply equal []

The 8 new /finance/* routes have no PAGE_TOUR_KEYS entry, so the dock's ? falls back to the generic overview on every finance page, and test-and-lint is red for every branch built on master.

Fix

  • PAGE_TOUR_KEYS entries for finance, finance/donations, finance/funds, finance/sales and finance/reports/{statement,receipts,year-over-year}, each with title/what/how copy in pageTours/en.json, and Spanish in es.json under _review: ["*"].
  • finance/ledger loads the same component as admin/operating-ledger, so it shares the adminOperatingLedger tour and its step regions. That copy said "Staff only", which is wrong now; it says "Staff and the finance role" (Spanish what added to its _review).

Acceptance criteria

  • page-tour.registry.spec.ts green
  • the copy names only labels that exist in the finance UI

Found during the 2026-10-02 dependency-refresh ticket round; fixed in spikerj/spikersoft-angular#1424.

## Bug `page-tour.registry.spec.ts › maps every dock-bearing route to an overview` fails on master since the finance-user merge (spikersoft-angular#1415): ``` AssertionError: expected [ 'finance', 'finance/ledger', …(6) ] to deeply equal [] ``` The 8 new `/finance/*` routes have no `PAGE_TOUR_KEYS` entry, so the dock's **?** falls back to the generic overview on every finance page, and `test-and-lint` is red for every branch built on master. ## Fix - `PAGE_TOUR_KEYS` entries for `finance`, `finance/donations`, `finance/funds`, `finance/sales` and `finance/reports/{statement,receipts,year-over-year}`, each with title/what/how copy in `pageTours/en.json`, and Spanish in `es.json` under `_review: ["*"]`. - `finance/ledger` loads the same component as `admin/operating-ledger`, so it shares the `adminOperatingLedger` tour and its step regions. That copy said "Staff only", which is wrong now; it says "Staff and the finance role" (Spanish `what` added to its `_review`). ## Acceptance criteria - [ ] `page-tour.registry.spec.ts` green - [ ] the copy names only labels that exist in the finance UI --- _Found during the 2026-10-02 dependency-refresh ticket round; fixed in spikerj/spikersoft-angular#1424._
spikerj added the bug label 2026-10-02 08:46:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#1177