[Bug] page-tour registry spec red on master: 8 /finance routes from #1415 have no page tour #1177

Closed
opened 2026-10-02 08:46:00 +00:00 by spikerj · 1 comment
Owner

Bug

page-tour.registry.spec.ts › maps every dock-bearing route to an overview fails on master since the finance-user merge (spikersoft-angular#1415):

AssertionError: expected [ 'finance', 'finance/ledger', …(6) ] to deeply equal []

The 8 new /finance/* routes have no PAGE_TOUR_KEYS entry, so the dock's ? falls back to the generic overview on every finance page, and test-and-lint is red for every branch built on master.

Fix

  • PAGE_TOUR_KEYS entries for finance, finance/donations, finance/funds, finance/sales and finance/reports/{statement,receipts,year-over-year}, each with title/what/how copy in pageTours/en.json, and Spanish in es.json under _review: ["*"].
  • finance/ledger loads the same component as admin/operating-ledger, so it shares the adminOperatingLedger tour and its step regions. That copy said "Staff only", which is wrong now; it says "Staff and the finance role" (Spanish what added to its _review).

Acceptance criteria

  • page-tour.registry.spec.ts green
  • the copy names only labels that exist in the finance UI

Found during the 2026-10-02 dependency-refresh ticket round; fixed in spikerj/spikersoft-angular#1424.

## Bug `page-tour.registry.spec.ts › maps every dock-bearing route to an overview` fails on master since the finance-user merge (spikersoft-angular#1415): ``` AssertionError: expected [ 'finance', 'finance/ledger', …(6) ] to deeply equal [] ``` The 8 new `/finance/*` routes have no `PAGE_TOUR_KEYS` entry, so the dock's **?** falls back to the generic overview on every finance page, and `test-and-lint` is red for every branch built on master. ## Fix - `PAGE_TOUR_KEYS` entries for `finance`, `finance/donations`, `finance/funds`, `finance/sales` and `finance/reports/{statement,receipts,year-over-year}`, each with title/what/how copy in `pageTours/en.json`, and Spanish in `es.json` under `_review: ["*"]`. - `finance/ledger` loads the same component as `admin/operating-ledger`, so it shares the `adminOperatingLedger` tour and its step regions. That copy said "Staff only", which is wrong now; it says "Staff and the finance role" (Spanish `what` added to its `_review`). ## Acceptance criteria - [ ] `page-tour.registry.spec.ts` green - [ ] the copy names only labels that exist in the finance UI --- _Found during the 2026-10-02 dependency-refresh ticket round; fixed in spikerj/spikersoft-angular#1424._
spikerj added the bug label 2026-10-02 08:46:00 +00:00
Author
Owner

Tracker sweep 2026-10-06. Closing: fixed by spikerj/spikersoft-angular#1424 (merged 2026-10-02).

Gitea only auto-closes issues in the same repo, so this one stayed open. Checked against angular master:

  • page-tour.registry.ts:169-176 maps all 8 /finance/* routes. finance/ledger shares adminOperatingLedger, and the other seven have their own finance* tours.
  • The shared ledger tour copy in pageTours/en.json now reads "Staff and the finance role…".
  • The spec has been green since. spikerj/spikersoft-angular#1421's 2026-10-04 update notes that the later page-tour.registry red on master was fixed by #1453.
**Tracker sweep 2026-10-06. Closing: fixed by spikerj/spikersoft-angular#1424 (merged 2026-10-02).** Gitea only auto-closes issues in the same repo, so this one stayed open. Checked against angular `master`: - `page-tour.registry.ts:169-176` maps all 8 `/finance/*` routes. `finance/ledger` shares `adminOperatingLedger`, and the other seven have their own `finance*` tours. - The shared ledger tour copy in `pageTours/en.json` now reads "Staff and the finance role…". - The spec has been green since. spikerj/spikersoft-angular#1421's 2026-10-04 update notes that the later `page-tour.registry` red on master was fixed by #1453.
Sign in to join this conversation.