[Bug] SonarQube S4275: property setter assigns the wrong field (FileUploadScan) #240

New Issue

2026-06-19T18:44:00Z

spikerj commented

2026-06-19 18:44:00 +00:00

Surfaced by SonarQube (api.spikersoft.com), rule csharpsquid:S4275, severity CRITICAL (RELIABILITY).

Problem

A property setter refers to a different field than its getter, so writes silently do not affect the value the getter returns. This is a genuine logic bug.

Location

spikersoft-backend/SpikerSoft.Data/Mongos/FileUploadScan.cs:33 — "Refactor this setter so that it actually refers to the field _status."

Fix

Point the setter at _status (the same field the getter reads) and add/verify a test that round-trips the property.

Rule: https://rules.sonarsource.com/csharp/RSPEC-4275/

Surfaced by SonarQube (`api.spikersoft.com`), rule `csharpsquid:S4275`, severity CRITICAL (RELIABILITY). ## Problem A property setter refers to a different field than its getter, so writes silently do not affect the value the getter returns. This is a genuine logic bug. ## Location - `spikersoft-backend/SpikerSoft.Data/Mongos/FileUploadScan.cs:33` — "Refactor this setter so that it actually refers to the field `_status`." ## Fix Point the setter at `_status` (the same field the getter reads) and add/verify a test that round-trips the property. _Rule: https://rules.sonarsource.com/csharp/RSPEC-4275/_

spikerj added the bug sonarqube labels 2026-06-19 18:44:00 +00:00

spikerj commented

2026-06-20 02:03:18 +00:00

Resolved in spikersoft-backend PR #12 (merged to master). FileUploadScan.Status setter now assigns _status instead of the compiler field, so status writes are no longer dropped. Closing.

Resolved in spikersoft-backend PR #12 (merged to `master`). `FileUploadScan.Status` setter now assigns `_status` instead of the compiler `field`, so status writes are no longer dropped. Closing.

spikerj closed this issue

2026-06-20 02:03:37 +00:00

spikerj referenced this issue

2026-07-12 19:12:23 +00:00

[Exploration][Infra] Resilience to SERVER node flaps — restart-policy windows, auto-reconcile sweep, de-SPOF the SERVER-pinned stateful tier #510

spikerj referenced this issue

2026-07-12 20:28:56 +00:00

[Bug][Infra] jaeger_elasticsearch down ~24h on SERVER (exit 1) — MaxAttempts exhausted, tracing backend offline #481

spikerj referenced this issue

2026-07-12 21:27:00 +00:00

[Bug][Infra][Deploy] docker-monitor: new correctly-named stack exits 0 on startup (stuck 0/1) + duplicate misspelled 'spiekersoft-docker-monitor' stack running in parallel #513

Sign in to join this conversation.