spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[Tech debt] SonarQube S4487: remove unread private fields (12 backend) #245

New Issue
Closed
opened 2026-06-19 18:44:52 +00:00 by spikerj · 1 comment
spikerj commented 2026-06-19 18:44:52 +00:00
Owner
Copy Link
Copy Source

Surfaced by SonarQube (api.spikersoft.com), rule csharpsquid:S4487, severity CRITICAL (MAINTAINABILITY). Private fields that are assigned but never read — dead state, often a leftover injected dependency. Easy wins (delete field + constructor param, or actually use it).

Locations

  • SpikerSoft.Api/Domain/CodeExecution/CodeSubmissionsController.cs:23 (_logger)
  • SpikerSoft.Business/Services/QuizAnalyticsService.cs:264 (TotalChanges)
  • SpikerSoft.EventHandlers.MetadataExtractor/Services/MetadataExtractionService.cs:30 (_configuration)
  • SpikerSoft.EventHandlers.UploadCoordinator/Services/UploadOrchestrator.cs:27 (_configuration)
  • SpikerSoft.Api/Domain/Assessment/AssessmentController.cs:20 (_assessmentReportService)
  • SpikerSoft.Api/Domain/Assessment/AssessmentController.cs:21 (_quizAttemptService)
  • SpikerSoft.Api/Domain/AddressTypes/AddressTypesController.cs:35 (_logger)
  • SpikerSoft.Api/Middleware/RedisRateLimitMiddleware.cs:15 (_options)
  • SpikerSoft.Business/Domain/Tools/Networking/Ping/PingCommandHandler.cs:13 (_configuration)
  • SpikerSoft.Business/Domain/Twilio/Commands/ProcessTwilioWebhook/ProcessTwilioWebhookCommandHandler.cs:23 (_configuration)
  • SpikerSoft.Business/Domain/Twilio/Commands/ProcessVerifyWebhook/ProcessVerifyWebhookCommandHandler.cs:22 (_configuration)
  • SpikerSoft.Business/ToolsManager.cs:13 (_mongoClient)

Rule: https://rules.sonarsource.com/csharp/RSPEC-4487/

Surfaced by SonarQube (`api.spikersoft.com`), rule `csharpsquid:S4487`, severity CRITICAL (MAINTAINABILITY). Private fields that are assigned but never read — dead state, often a leftover injected dependency. Easy wins (delete field + constructor param, or actually use it). ## Locations - `SpikerSoft.Api/Domain/CodeExecution/CodeSubmissionsController.cs:23` (`_logger`) - `SpikerSoft.Business/Services/QuizAnalyticsService.cs:264` (`TotalChanges`) - `SpikerSoft.EventHandlers.MetadataExtractor/Services/MetadataExtractionService.cs:30` (`_configuration`) - `SpikerSoft.EventHandlers.UploadCoordinator/Services/UploadOrchestrator.cs:27` (`_configuration`) - `SpikerSoft.Api/Domain/Assessment/AssessmentController.cs:20` (`_assessmentReportService`) - `SpikerSoft.Api/Domain/Assessment/AssessmentController.cs:21` (`_quizAttemptService`) - `SpikerSoft.Api/Domain/AddressTypes/AddressTypesController.cs:35` (`_logger`) - `SpikerSoft.Api/Middleware/RedisRateLimitMiddleware.cs:15` (`_options`) - `SpikerSoft.Business/Domain/Tools/Networking/Ping/PingCommandHandler.cs:13` (`_configuration`) - `SpikerSoft.Business/Domain/Twilio/Commands/ProcessTwilioWebhook/ProcessTwilioWebhookCommandHandler.cs:23` (`_configuration`) - `SpikerSoft.Business/Domain/Twilio/Commands/ProcessVerifyWebhook/ProcessVerifyWebhookCommandHandler.cs:22` (`_configuration`) - `SpikerSoft.Business/ToolsManager.cs:13` (`_mongoClient`) _Rule: https://rules.sonarsource.com/csharp/RSPEC-4487/_
spikerj added the sonarqube label 2026-06-19 18:44:52 +00:00
spikerj commented 2026-06-20 02:03:25 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #12 (merged to master). Removed 11 unread injected fields plus their now-dead ctor params/args across controllers, middleware, handlers and services, and updated all call sites and tests. Closing.

Resolved in spikersoft-backend PR #12 (merged to `master`). Removed 11 unread injected fields plus their now-dead ctor params/args across controllers, middleware, handlers and services, and updated all call sites and tests. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels sonarqube
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#245