spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[Tech debt] SonarQube S2696: static field written from instance method (3 backend) #247

New Issue
Closed
opened 2026-06-19 18:44:59 +00:00 by spikerj · 1 comment
spikerj commented 2026-06-19 18:44:59 +00:00
Owner
Copy Link
Copy Source

Surfaced by SonarQube (api.spikersoft.com), rule csharpsquid:S2696, severity CRITICAL (MAINTAINABILITY). Updating static state from an instance method is a thread-safety / shared-state hazard.

Locations

  • SpikerSoft.Business/Services/PostalCodeSeederService.cs:35
  • SpikerSoft.Business/Services/PostalCodeSeederService.cs:36
  • SpikerSoft.Business.Ai.Workers/Services/BookAnalysisService.cs:511

Fix

Make the field instance-scoped, or make the method static, or guard the shared write appropriately.

Rule: https://rules.sonarsource.com/csharp/RSPEC-2696/

Surfaced by SonarQube (`api.spikersoft.com`), rule `csharpsquid:S2696`, severity CRITICAL (MAINTAINABILITY). Updating `static` state from an instance method is a thread-safety / shared-state hazard. ## Locations - `SpikerSoft.Business/Services/PostalCodeSeederService.cs:35` - `SpikerSoft.Business/Services/PostalCodeSeederService.cs:36` - `SpikerSoft.Business.Ai.Workers/Services/BookAnalysisService.cs:511` ## Fix Make the field instance-scoped, or make the method `static`, or guard the shared write appropriately. _Rule: https://rules.sonarsource.com/csharp/RSPEC-2696/_
spikerj added the sonarqube label 2026-06-19 18:44:59 +00:00
spikerj commented 2026-06-20 02:03:28 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #12 (merged to master). Static-state writes in PostalCodeSeederService and BookAnalysisService now go through static helper methods, so instance methods no longer mutate static fields directly. Closing.

Resolved in spikersoft-backend PR #12 (merged to `master`). Static-state writes in `PostalCodeSeederService` and `BookAnalysisService` now go through static helper methods, so instance methods no longer mutate static fields directly. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels sonarqube
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#247